You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/21 02:23:48 UTC

[GitHub] [incubator-apisix] moonming opened a new issue #1877: request help: add version in http response `server` header

moonming opened a new issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877


   Apache APISIX only return `server: APISIX`, we need to add version like `server: APISIX/1.4`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] swayamraina commented on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-666562486


   @moonming I have made the required changes however I am unable to run test-cases (new to writing tests inn perl/lua).
   Can you please help to understand how to setup/run TCs
   
   thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] swayamraina edited a comment on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
swayamraina edited a comment on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-666562486


   @moonming I have made the required changes (in core/response.lua) however I am unable to run test-cases (new to writing tests in perl/lua).
   Can you please help to understand how to setup/run TCs
   
   thanks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] swayamraina edited a comment on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
swayamraina edited a comment on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-666562486


   @moonming I have made the required changes however I am unable to run test-cases (new to writing tests inn perl/lua).
   Can you please help to understand how to setup/run TCs
   
   thanks
   
   ```
   Can't locate Test/Nginx/Socket/Lua/Stream.pm in @INC (you may need to install the Test::Nginx::Socket::Lua::Stream module)(@INC contains: 
   lib /Library/Perl/5.18/darwin-thread-multi-2level 
   /Library/Perl/5.18 /Network/Library/Perl/5.18/darwin-thread-multi-2level /Network/Library/Perl/5.18 /Library/Perl/Updates/5.18.2 /System/Library/Perl/5.18/darwin-thread-multi-2level /System/Library/Perl/5.18 
   /System/Library/Perl/Extras/5.18/darwin-thread-multi-2level /System/Library/Perl/Extras/5.18 .) 
   at t/APISIX.pm line 21.
   BEGIN failed--compilation aborted at t/APISIX.pm line 21.
   Compilation failed in require at t/core/response.t line 17.
   BEGIN failed--compilation aborted at t/core/response.t line 17.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-661582219


   we can remove https://github.com/apache/incubator-apisix/blob/master/bin/apisix#L241, and use lua code to add http header 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-667072442


   you can submit your code first. then I will help you where is the problem. ^_^ @swayamraina 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] swayamraina edited a comment on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
swayamraina edited a comment on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-666562486


   @moonming I have made the required changes however I am unable to run test-cases (new to writing tests inn perl/lua).
   Can you please help to understand how to setup/run TCs
   
   thanks
   
   ```
   Can't locate Test/Nginx/Socket/Lua/Stream.pm in @INC (you may need to install the Test::Nginx::Socket::Lua::Stream module)(@INC contains: 
   lib /Library/Perl/5.18/darwin-thread-multi-2level 
   /Library/Perl/5.18
   /Network/Library/Perl/5.18/darwin-thread-multi-2level 
   /Network/Library/Perl/5.18 /Library/Perl/Updates/5.18.2 
   /System/Library/Perl/5.18/darwin-thread-multi-2level 
   /System/Library/Perl/5.18 
   /System/Library/Perl/Extras/5.18/darwin-thread-multi-2level /System/Library/Perl/Extras/5.18 .) 
   at t/APISIX.pm line 21.
   BEGIN failed--compilation aborted at t/APISIX.pm line 21.
   Compilation failed in require at t/core/response.t line 17.
   BEGIN failed--compilation aborted at t/core/response.t line 17.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] swayamraina commented on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-667068368


   @membphis can you please help here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] swayamraina edited a comment on issue #1877: request help: add version in http response `server` header

Posted by GitBox <gi...@apache.org>.
swayamraina edited a comment on issue #1877:
URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-666562486


   @moonming I have made the required changes however I am unable to run test-cases (new to writing tests in perl/lua).
   Can you please help to understand how to setup/run TCs
   
   thanks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org