You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Anthony Carlucci (JIRA)" <ji...@apache.org> on 2012/05/16 19:31:02 UTC

[jira] [Created] (RAVE-621) trimDirectiveWhitespaces JSP directive being ignored

Anthony Carlucci created RAVE-621:
-------------------------------------

             Summary: trimDirectiveWhitespaces JSP directive being ignored
                 Key: RAVE-621
                 URL: https://issues.apache.org/jira/browse/RAVE-621
             Project: Rave
          Issue Type: Bug
    Affects Versions: 0.11
            Reporter: Anthony Carlucci
            Assignee: Anthony Carlucci
            Priority: Minor


The trimDirectiveWhitespaces="true" JSP page directive is being ignored.  HTML content still has large sections of empty whitespace that is not getting stripped out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (RAVE-621) trimDirectiveWhitespaces JSP directive being ignored

Posted by "marijan milicevic (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RAVE-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294412#comment-13294412 ] 

marijan milicevic commented on RAVE-621:
----------------------------------------

I just tested this and it doesn't seem to be ignored. An easy way to test is to set trimDirectiveWhitespaces to false within
rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/login.jsp and compare results.

                
> trimDirectiveWhitespaces JSP directive being ignored
> ----------------------------------------------------
>
>                 Key: RAVE-621
>                 URL: https://issues.apache.org/jira/browse/RAVE-621
>             Project: Rave
>          Issue Type: Bug
>    Affects Versions: 0.11
>            Reporter: Anthony Carlucci
>            Assignee: Anthony Carlucci
>            Priority: Minor
>
> The trimDirectiveWhitespaces="true" JSP page directive is being ignored.  HTML content still has large sections of empty whitespace that is not getting stripped out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (RAVE-621) trimDirectiveWhitespaces JSP directive being ignored

Posted by "Mickaël Tricot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAVE-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mickaël Tricot updated RAVE-621:
--------------------------------

    Attachment: RAVE-621.patch

A good way to enforce "trimDirectiveWhitespaces" in all *.jsp and *.tag files is to add this piece of configuration in the web.xml:

<jsp-config>
    <jsp-property-group>
        <url-pattern>*.jsp</url-pattern>
        <trim-directive-whitespaces>true</trim-directive-whitespaces>
    </jsp-property-group>
    <jsp-property-group>
        <url-pattern>*.tag</url-pattern>
        <trim-directive-whitespaces>true</trim-directive-whitespaces>
    </jsp-property-group>
</jsp-config>

Also see the patch attached.
                
> trimDirectiveWhitespaces JSP directive being ignored
> ----------------------------------------------------
>
>                 Key: RAVE-621
>                 URL: https://issues.apache.org/jira/browse/RAVE-621
>             Project: Rave
>          Issue Type: Bug
>    Affects Versions: 0.11
>            Reporter: Anthony Carlucci
>            Assignee: Anthony Carlucci
>            Priority: Minor
>         Attachments: RAVE-621.patch
>
>
> The trimDirectiveWhitespaces="true" JSP page directive is being ignored.  HTML content still has large sections of empty whitespace that is not getting stripped out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira