You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/06/18 20:17:03 UTC
Review Request: Add APIs to get runtime system information.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5392/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Add utility functions to get runtime system information.
For example, we can get the kernel version (e.g. version.major.minor), the operating system name (e.g. Linux, Darwin, etc), and so on.
These utilities are based the "uname" system call.
Diffs
-----
src/common/utils.hpp ba55497
src/tests/utils_tests.cpp 0e3374e
Diff: https://reviews.apache.org/r/5392/diff/
Testing
-------
Tested on Linux and Mac.
make check
Thanks,
Jie Yu
Re: Review Request: Add APIs to get runtime system information.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5392/#review8354
-----------------------------------------------------------
src/common/utils.hpp
<https://reviews.apache.org/r/5392/#comment18025>
Done.
src/tests/utils_tests.cpp
<https://reviews.apache.org/r/5392/#comment18031>
Seems that we don't have an oracle to compare with. I manually tested this both on Mac and Linux.
- Jie Yu
On June 18, 2012, 6:17 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5392/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Add utility functions to get runtime system information.
>
> For example, we can get the kernel version (e.g. version.major.minor), the operating system name (e.g. Linux, Darwin, etc), and so on.
>
> These utilities are based the "uname" system call.
>
>
> Diffs
> -----
>
> src/common/utils.hpp ba55497
> src/tests/utils_tests.cpp 0e3374e
>
> Diff: https://reviews.apache.org/r/5392/diff/
>
>
> Testing
> -------
>
> Tested on Linux and Mac.
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Add APIs to get runtime system information.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5392/#review8338
-----------------------------------------------------------
src/common/utils.hpp
<https://reviews.apache.org/r/5392/#comment17980>
I'm pretty sure "uts" is an acronym, so it should be in all caps, i.e., UTS. Also, since you seem to like using the variable name 'info' for this structure, why not call this UTSInfo? It differentiates it from utsname, which might also be useful.
src/tests/utils_tests.cpp
<https://reviews.apache.org/r/5392/#comment18024>
If you wanted to make this a more "robust" test you could consider, at least on Linux, checking the Linux kernel version.
- Benjamin Hindman
On June 18, 2012, 6:17 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5392/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Add utility functions to get runtime system information.
>
> For example, we can get the kernel version (e.g. version.major.minor), the operating system name (e.g. Linux, Darwin, etc), and so on.
>
> These utilities are based the "uname" system call.
>
>
> Diffs
> -----
>
> src/common/utils.hpp ba55497
> src/tests/utils_tests.cpp 0e3374e
>
> Diff: https://reviews.apache.org/r/5392/diff/
>
>
> Testing
> -------
>
> Tested on Linux and Mac.
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Add APIs to get runtime system information.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5392/#review8397
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 18, 2012, 10:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5392/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 10:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Add utility functions to get runtime system information.
>
> For example, we can get the kernel version (e.g. version.major.minor), the operating system name (e.g. Linux, Darwin, etc), and so on.
>
> These utilities are based the "uname" system call.
>
>
> Diffs
> -----
>
> src/common/utils.hpp ba55497
> src/tests/utils_tests.cpp 0e3374e
>
> Diff: https://reviews.apache.org/r/5392/diff/
>
>
> Testing
> -------
>
> Tested on Linux and Mac.
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Add APIs to get runtime system information.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5392/
-----------------------------------------------------------
(Updated June 18, 2012, 10:19 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Addressed Ben's review feedback.
Description
-------
Add utility functions to get runtime system information.
For example, we can get the kernel version (e.g. version.major.minor), the operating system name (e.g. Linux, Darwin, etc), and so on.
These utilities are based the "uname" system call.
Diffs (updated)
-----
src/common/utils.hpp ba55497
src/tests/utils_tests.cpp 0e3374e
Diff: https://reviews.apache.org/r/5392/diff/
Testing
-------
Tested on Linux and Mac.
make check
Thanks,
Jie Yu