You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/02/04 08:22:38 UTC
Review Request 56301: The program can not get the correct version
when we installed Ranger KMS based on the latest version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56301/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1323
https://issues.apache.org/jira/browse/RANGER-1323
Repository: ranger
Description
-------
The program can not get the correct version when we installed Ranger KMS based on the latest version. The code logical is as follows:
if [ -f ${PWD}/version ]
then
VERSION=`cat ${PWD}/version`
else
VERSION="0.5.0"
fi
There are two logical errors in above code.
1. The version file does not exist. VERSION can only be equal to 0.5.0.
2. VERSION=`cat ${PWD}/version` clause can only get version information from file with unapproved license. However, the ranger project does not support file of this format.
We should add version file into kms install path. The current version should be writed in the version file.
Diffs
-----
kms/scripts/setup.sh f31e0e2
kms/scripts/version PRE-CREATION
Diff: https://reviews.apache.org/r/56301/diff/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 56301: The program can not get the correct version
when we installed Ranger KMS based on the latest version
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56301/
-----------------------------------------------------------
(Updated \u4e8c\u6708 6, 2017, 5:58 a.m.)
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1323
https://issues.apache.org/jira/browse/RANGER-1323
Repository: ranger
Description (updated)
-------
The program can not get the correct version when we installed Ranger KMS based on the latest version. The code logical is as follows:
if [ -f ${PWD}/version ]
then
VERSION=`cat ${PWD}/version`
else
VERSION="0.5.0"
fi
There are two logical errors in above code.
1. The version file does not exist. VERSION can only be equal to 0.5.0.
2. VERSION=`cat ${PWD}/version` clause can only get version information from file with unapproved license. However, the ranger project does not support file of this format.
We should add version file into kms install path. The current version should be written in the version file.
Diffs
-----
kms/scripts/setup.sh f31e0e2
kms/scripts/version PRE-CREATION
Diff: https://reviews.apache.org/r/56301/diff/
Testing
-------
Thanks,
Qiang Zhang