[GitHub] [incubator-iceberg] shawnding removed a comment on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

[GitBox <gi...@apache.org>]

shawnding removed a comment on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'
URL: https://github.com/apache/incubator-iceberg/pull/688#issuecomment-569889919
 
 
   > @shawnding, looks like you accidentally closed one of my review comments that wasn't addressed (please be more careful):
   > 
   > > What happens when the location URI is not set on the Database passed to Hive? Does Hive assign one itself?
   > > If Hive assigns a location, then I think this doesn't need to check that the client's warehouse location is set.
   > 
   > I'd still like to find out what happens in this case.
   
   HI Ryan, in this case, I have checked the hiveMetaStore behavior. When the location URI is not set on the databases, Hive will assign the value of `hive.metastore.warehouse.dir`  as the default location. The property `hive.metastore.warehouse.dir ` always has a default value. But It will change the database name to lower case in path.  So I removed the `location` check and closed the comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org