You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/12/25 05:15:16 UTC

[GitHub] spark pull request #20073: [SPARK-22843][R] Adds localCheckpoint in R

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20073

    [SPARK-22843][R] Adds localCheckpoint in R

    ## What changes were proposed in this pull request?
    
    This PR proposes to add `localCheckpoint(..)` in R API.
    
    ```r
    df <- localCheckpoint(createDataFrame(iris))
    ```
    
    ## How was this patch tested?
    
    Unit tests added in `R/pkg/tests/fulltests/test_sparkSQL.R`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-22843

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20073.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20073
    
----
commit ec27a80be663ab29ae563a3a9ca8f2a0d32436d5
Author: hyukjinkwon <gu...@...>
Date:   2017-12-25T04:58:15Z

    Adds localCheckpoint in R

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    **[Test build #85364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85364/testReport)** for PR 20073 at commit [`ec27a80`](https://github.com/apache/spark/commit/ec27a80be663ab29ae563a3a9ca8f2a0d32436d5).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    I tried to check if there is a easier way but not sure. Scala side seems checking the plan as well but I think I can't simply do it in R side and don't think it's worth ..


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    **[Test build #85364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85364/testReport)** for PR 20073 at commit [`ec27a80`](https://github.com/apache/spark/commit/ec27a80be663ab29ae563a3a9ca8f2a0d32436d5).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    cc @felixcheung, could you check if I understood your intention correctly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85364/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    Yes LGTM
    Btw is there a better way to test localCheckpoint that it is not writing to checkpointDir?
    
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20073
  
    Merged to master.
    
    Thank you @felixcheung.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org