You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2017/05/15 09:18:57 UTC
[GitHub] flink pull request #3900: [FLINK-6580] Sync default heap sizes from code wit...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/3900
[FLINK-6580] Sync default heap sizes from code with config file
Flink didn't start on YARN anymore without explicit configuration of JM and TM heap because the default heap sizes in the yaml file were set too low.
This PR increases the default heap sizes according to the `TaskManagerOptions` and `JobManagerOptions` classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink FLINK-6580
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3900.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3900
----
commit d115416613313f5d01a47e92c33e87b3075008e8
Author: Robert Metzger <rm...@apache.org>
Date: 2017-05-15T09:15:48Z
[FLINK-6580] Sync default heap sizes from code with config file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3900: [FLINK-6580] Sync default heap sizes from code with confi...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3900
@zentol do you agree to merge this now. Its the last thing I would like to get into RC1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3900: [FLINK-6580] Sync default heap sizes from code with confi...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3900
Do we know the underlying reason that is causing YARN to fail now? None of the config values seem to have changed in a long time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3900: [FLINK-6580] Sync default heap sizes from code with confi...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3900
+1 to merge after you've changed it back to 1024.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3900: [FLINK-6580] Sync default heap sizes from code wit...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3900#discussion_r116487520
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java ---
@@ -62,7 +62,7 @@
*/
public static final ConfigOption<Integer> JOB_MANAGER_HEAP_MEMORY =
key("jobmanager.heap.mb")
- .defaultValue(1024);
+ .defaultValue(768);
--- End diff --
Why not 1024?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3900: [FLINK-6580] Sync default heap sizes from code with confi...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3900
nvm, found the reference to FLINK-5904 in the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3900: [FLINK-6580] Sync default heap sizes from code wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3900: [FLINK-6580] Sync default heap sizes from code wit...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3900#discussion_r116492253
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java ---
@@ -62,7 +62,7 @@
*/
public static final ConfigOption<Integer> JOB_MANAGER_HEAP_MEMORY =
key("jobmanager.heap.mb")
- .defaultValue(1024);
+ .defaultValue(768);
--- End diff --
Yeah, I'll go back to 1024.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---