You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by us...@apache.org on 2015/11/09 00:44:24 UTC
svn commit: r1713324 - in /poi/trunk/src/java/org/apache/poi/util:
FontMetricsDumper.java LocaleUtil.java SuppressForbidden.java
Author: uschindler
Date: Sun Nov 8 23:44:24 2015
New Revision: 1713324
URL: http://svn.apache.org/viewvc?rev=1713324&view=rev
Log:
Add reason message to @SuppressForbidden
Modified:
poi/trunk/src/java/org/apache/poi/util/FontMetricsDumper.java
poi/trunk/src/java/org/apache/poi/util/LocaleUtil.java
poi/trunk/src/java/org/apache/poi/util/SuppressForbidden.java
Modified: poi/trunk/src/java/org/apache/poi/util/FontMetricsDumper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/FontMetricsDumper.java?rev=1713324&r1=1713323&r2=1713324&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/FontMetricsDumper.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/FontMetricsDumper.java Sun Nov 8 23:44:24 2015
@@ -29,7 +29,7 @@ import java.util.Properties;
@SuppressWarnings("deprecation")
public class FontMetricsDumper
{
- @SuppressForbidden
+ @SuppressForbidden("command line tool")
public static void main( String[] args ) throws IOException
{
Modified: poi/trunk/src/java/org/apache/poi/util/LocaleUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/LocaleUtil.java?rev=1713324&r1=1713323&r2=1713324&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/LocaleUtil.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/LocaleUtil.java Sun Nov 8 23:44:24 2015
@@ -50,7 +50,7 @@ public class LocaleUtil {
private static final ThreadLocal<TimeZone> userTimeZone = new ThreadLocal<TimeZone>() {
@Override
- @SuppressForbidden
+ @SuppressForbidden("implementation around default locales in POI")
protected TimeZone initialValue() {
return TimeZone.getDefault();
}
@@ -58,7 +58,7 @@ public class LocaleUtil {
private static final ThreadLocal<Locale> userLocale = new ThreadLocal<Locale>() {
@Override
- @SuppressForbidden
+ @SuppressForbidden("implementation around default locales in POI")
protected Locale initialValue() {
return Locale.getDefault();
}
Modified: poi/trunk/src/java/org/apache/poi/util/SuppressForbidden.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/SuppressForbidden.java?rev=1713324&r1=1713323&r2=1713324&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/SuppressForbidden.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/SuppressForbidden.java Sun Nov 8 23:44:24 2015
@@ -22,11 +22,12 @@ import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
-/*
+/**
* Marking class for elements to be ignored by the forbidden apis check
*/
@Retention(RetentionPolicy.CLASS)
@Target({ElementType.METHOD, ElementType.TYPE})
public @interface SuppressForbidden {
-
+ /** A reason for suppressing should always be given. */
+ String value() default "";
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org