[jira] [Commented] (SCB-180) Circuitbreak forceopen always true

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312783#comment-16312783 ] 

ASF GitHub Bot commented on SCB-180:
------------------------------------

mojieshui commented on issue #490: [SCB-180] Hystrixcommand setter not set by dynamic configuration
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355513038
 
 
   @wujimin @liubao68 @WillemJiang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Circuitbreak forceopen always true
> ----------------------------------
>
>                 Key: SCB-180
>                 URL: https://issues.apache.org/jira/browse/SCB-180
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m1
>            Reporter: mojieshui
>            Assignee: mojieshui
>
> when use dynamic config with ConfigCenterConfigurationSource
> reproduce steps:
> 1. add dynamic config item "servicecomb.circuitBreaker.Consumer.forceOpen=true"
> 2. make any request, hystrixcommand will init and cached. the circuitbreaker is open. 
> 3. delete dynamic config item "servicecomb.circuitBreaker.Consumer.forceOpen", Expected result is circuitbreaker change to the default value "false", but it keep always true, all request fail.
> in class HystrixCommandPropertiesExt
>     this.circuitBreakerForceOpen = getProperty(propertyPrefix,
>         "circuitBreaker",
>         key,
>         "forceOpen",
>         {color:#d04437}builder.getCircuitBreakerForceOpen(),
> {color}        DEFAULT_CIRCUITBREAKERFORCEOPEN);
> and builder's value was set by dynamic config, not the default value false, if config was set before hystixcommand init, default value will override, and you have to restart if you want to restore
>       .withCircuitBreakerForceOpen(Configuration.INSTANCE.isCircuitBreakerForceOpen(groupname,
>             invocation.getMicroserviceName(),
>             invocation.getOperationMeta()
>                 .getMicroserviceQualifiedName()))



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)