You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/07/01 01:39:38 UTC
[PR] MINOR: [R] Fix lint errors [arrow]
kou opened a new pull request, #46955:
URL: https://github.com/apache/arrow/pull/46955
### Rationale for this change
They are introduced by #46651
https://github.com/apache/arrow/actions/runs/15987292796/job/45094044698#step:5:18
```text
R Lint...................................................................Failed
- hook id: lintr
- exit code: 1
Error: Not lint free
tests/testthat/test-Array.R:355:57: style: [brace_linter] Opening curly braces should never go on their own line and should always be followed by a new line.
test_that("array supports integer64 with new sematics", {
^
tests/testthat/test-Array.R:356:58: style: [brace_linter] Opening curly braces should never go on their own line and should always be followed by a new line.
withr::with_options(list(integer64_semantics = "new"), {
^
Error: estthat/test-Array.R:368:1: error: [error] unexpected '}'
})
^
Execution halted
25h
```
### What changes are included in this PR?
* Add missing `)`
* Fix a typo
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Fix lint errors [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46955:
URL: https://github.com/apache/arrow/pull/46955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Fix lint errors [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46955:
URL: https://github.com/apache/arrow/pull/46955#issuecomment-3023774167
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e74d186c79b20027b88d3f9d7c5d227490f43c9b.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `amd64-m5-4xlarge-linux` at [2025-07-01 07:20:11Z](https://conbench.ursa.dev/compare/runs/8fea9e6ba2d14ef1b931e734651b504f...e0ab827cdfc14ec993fde95d9f12c43f/)
- [`partitioned-dataset-filter` (R) with dataset=dataset-taxi-parquet, language=R, query=vignette](https://conbench.ursa.dev/compare/benchmarks/068636ff87597f52800048ef05bc5428...06863ae361887beb8000593072545279)
The [full Conbench report](https://github.com/apache/arrow/runs/45129339397) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Fix lint errors [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #46955:
URL: https://github.com/apache/arrow/pull/46955#issuecomment-3092588239
Thanks for fixing this 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org