You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/06/15 01:56:43 UTC

[jira] [Created] (CASSANDRA-4343) fix sstable blacklisting for LCS

Jonathan Ellis created CASSANDRA-4343:
-----------------------------------------

             Summary: fix sstable blacklisting for LCS
                 Key: CASSANDRA-4343
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4343
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1.0
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor
             Fix For: 1.1.2




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4343) fix sstable blacklisting for LCS

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4343:
--------------------------------------

    Attachment: 4343.txt

CompactionsTest failed after CASSANDRA-4341 but the cause was an existing bug in the blacklisting code.

Consider L0 sstables A and B and L1 sstable C.  A and B overlap with C, and C is suspect/blacklisted.  getCandidatesFor will return {A, B, C}, and getCompactionCandidates will then remove C from the candidate list.  A and B will be compacted to D in L1, so L1 will now contain two overlapping sstables C and D.

Patch to fix by check blacklist in getCandidatesFor.  If an overlapping sstable is suspect, we'll proceed to the next possible range instead of doing an incorrect compaction.  Overlapping suspect sstables in L0 are also handled.
                
> fix sstable blacklisting for LCS
> --------------------------------
>
>                 Key: CASSANDRA-4343
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4343
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.1.2
>
>         Attachments: 4343.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4343) fix sstable blacklisting for LCS

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295759#comment-13295759 ] 

Yuki Morishita commented on CASSANDRA-4343:
-------------------------------------------

+1 (I didn't see any test failure without patch, though.)
                
> fix sstable blacklisting for LCS
> --------------------------------
>
>                 Key: CASSANDRA-4343
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4343
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.1.2
>
>         Attachments: 4343.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira