[GitHub] [iceberg] rdblue commented on a change in pull request #1975: Core: add sort order id to content file

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1975:
URL: https://github.com/apache/iceberg/pull/1975#discussion_r549454696



##########
File path: core/src/main/java/org/apache/iceberg/DataFiles.java
##########
@@ -268,6 +271,11 @@ public Builder withEncryptionKeyMetadata(EncryptionKeyMetadata newKeyMetadata) {
       return withEncryptionKeyMetadata(newKeyMetadata.buffer());
     }
 
+    public Builder withSortOrderId(int newSortOrderId) {

Review comment:
       What about `withSortOrder`? Is there a case where we would only have the ID and not the `SortOrder`? Just trying to think of what will be convenient. We could always expose both methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org