You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/09/19 07:20:14 UTC
Review Request 25819: post-reviews.py: use --no-color with git log.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Force git log to never emit colored output (for setups with colored output enabled by default).
For example, the command "git --no-pager log --pretty=oneline --reverse master..HEAD" should generate output similiar to the following:
```
fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
```
However, in a setup where git emits colored output, the raw output would look like the following:
```
^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
```
The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes.
The '--no-color' flag forces git to never emit colored output.
Diffs
-----
support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e
Diff: https://reviews.apache.org/r/25819/diff/
Testing
-------
Created this review request using the updated script.
Thanks,
Kapil Arya
Re: Review Request 25819: post-reviews.py: use --no-color with git
log.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/#review54042
-----------------------------------------------------------
Ship it!
Thanks for updating the description on this one.
- Ben Mahler
On Sept. 19, 2014, 5:20 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25819/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 5:20 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Force git log to never emit colored output (for setups with colored output enabled by default).
>
> For example, the command "git --no-pager log --pretty=oneline --reverse master..HEAD" should generate output similiar to the following:
> ```
> fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
> ```
>
> However, in a setup where git emits colored output, the raw output would look like the following:
> ```
> ^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
> ```
>
> The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes.
>
> The '--no-color' flag forces git to never emit colored output.
>
>
> Diffs
> -----
>
> support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e
>
> Diff: https://reviews.apache.org/r/25819/diff/
>
>
> Testing
> -------
>
> Created this review request using the updated script.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 25819: post-reviews.py: use --no-color with git
log.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/#review53942
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25819]
All tests passed.
- Mesos ReviewBot
On Sept. 19, 2014, 5:20 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25819/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 5:20 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Force git log to never emit colored output (for setups with colored output enabled by default).
>
> For example, the command "git --no-pager log --pretty=oneline --reverse master..HEAD" should generate output similiar to the following:
> ```
> fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
> ```
>
> However, in a setup where git emits colored output, the raw output would look like the following:
> ```
> ^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
> ```
>
> The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes.
>
> The '--no-color' flag forces git to never emit colored output.
>
>
> Diffs
> -----
>
> support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e
>
> Diff: https://reviews.apache.org/r/25819/diff/
>
>
> Testing
> -------
>
> Created this review request using the updated script.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 25819: post-reviews.py: use --no-color with git
log.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/
-----------------------------------------------------------
(Updated Sept. 19, 2014, 1:20 a.m.)
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Force git log to never emit colored output (for setups with colored output enabled by default).
For example, the command "git --no-pager log --pretty=oneline --reverse master..HEAD" should generate output similiar to the following:
```
fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
```
However, in a setup where git emits colored output, the raw output would look like the following:
```
^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log.
```
The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes.
The '--no-color' flag forces git to never emit colored output.
Diffs
-----
support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e
Diff: https://reviews.apache.org/r/25819/diff/
Testing
-------
Created this review request using the updated script.
Thanks,
Kapil Arya