You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "pranav1699 (via GitHub)" <gi...@apache.org> on 2023/05/19 20:30:10 UTC

[GitHub] [iceberg-docs] pranav1699 opened a new pull request, #240: Fix: Added the "overflow" property for TableOfContents

pranav1699 opened a new pull request, #240:
URL: https://github.com/apache/iceberg-docs/pull/240

   In this page https://iceberg.apache.org/docs/latest/aws/ we can see there is a lot of items in TableOfContents and when we change the height of the browser window, some of the contents were not showing up in TableOfContents. So I've modified the iceberg-theme.css to add the overflow-y and height property for the "#toc" element.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] RussellSpitzer commented on pull request #240: Fix: Added the "overflow" property for TableOfContents

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #240:
URL: https://github.com/apache/iceberg-docs/pull/240#issuecomment-1636014363

   Can you add a picture or two to illustrate the change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] RussellSpitzer merged pull request #240: Fix: Added the "overflow" property for TableOfContents

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer merged PR #240:
URL: https://github.com/apache/iceberg-docs/pull/240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] RussellSpitzer commented on pull request #240: Fix: Added the "overflow" property for TableOfContents

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #240:
URL: https://github.com/apache/iceberg-docs/pull/240#issuecomment-1636328929

   Thanks! I am not good at web :) But that looks great to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] pranav1699 commented on pull request #240: Fix: Added the "overflow" property for TableOfContents

Posted by "pranav1699 (via GitHub)" <gi...@apache.org>.
pranav1699 commented on PR #240:
URL: https://github.com/apache/iceberg-docs/pull/240#issuecomment-1636321677

   Hi @RussellSpitzer , I've attached the GIF's below which will illustrate the changes.
   
   Before:
   
   ![6cdfe04c-e5cd-4175-9a01-8fba0f1cca88(1)](https://github.com/apache/iceberg-docs/assets/86850478/f7edee6d-134b-435c-ab4c-0c3fc96ee291)
   
   After:
   
   ![19dda67d-3637-4d80-a9e4-d913dbc8219c(2)](https://github.com/apache/iceberg-docs/assets/86850478/07d35e9e-c895-4ccf-b40b-85efdd1a315d)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org