You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "bossenti (via GitHub)" <gi...@apache.org> on 2023/02/01 19:00:47 UTC
[I] Remove deprecated UI dependencies (streampipes)
bossenti opened a new issue, #1196:
URL: https://github.com/apache/streampipes/issues/1196
### Body
When installing our UI dependencies, some deprecation warnings occur, see https://github.com/apache/streampipes/actions/runs/4050714717/jobs/6968365235#step:4:7.
This ticket is about removing/replacing them by their successors.
## Mentoring
As this ticket is marked as good first issue: one of @dominikriemer, @tenthe, @bossenti or @smlabt are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.
### StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413186370
@azher-alnabi welcome to StreamPipes 🎉
Yes that would be ideal.
But if a library cannot be replaced easily, we can also create a dedicated issue for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413223814
Yes, exactly 👍🏼
If you need any help, just let us know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1416863497
is there an equivalent to "npm run dev" to check if I have broken anything for this problem? @dominikriemer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413115101
Are you looking to replace all 11 depreciated dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413222426
Sorry, I'm a little new at this. Would I just have to fork streampipes, swap out Chokidar2 with 3 then open a PR? @bossenti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413189094
Sounds wonderful, is there any low-hanging fruit with regards to where you would like me to start? Also, what would you like me to replace them with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1427914552
I don't know if there is a tool to check the dependencies.
The best way I know is to run the test suite as @bossenti explained.
You can also create a PR. We have a PR validation that builds the project and runs the Cypress tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1414645952
I narrowed the Chokidar2 dependencies down to "node_modules/watchpack-chokidar2" in the UI folder. This is the biggest codebase I've opened, so I'm unsure if I'm looking at the correct file. This was under package-lock.json. Here is also what I'm looking at [watchpack](https://www.npmjs.com/package/watchpack?activeTab=versions), and [watchpack-chokidar2](https://www.npmjs.com/package/watchpack-chokidar2?activeTab=versions). Also, how would I do testing to make sure that if I changed something, it didn't break anything downstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1419639625
I think the most basic test is to build the UI like described in the [README](https://github.com/apache/streampipes/blob/dev/ui/README.md).
Ideally, you can run our cypress test suite which can be found [here](https://github.com/apache/streampipes/blob/dev/ui/README.md).
In terms of the dependencies itself, @tenthe @dominikriemer or @smlabt are the best contact persons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1415949354
@bossenti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413115361
@bossenti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413213398
I would guess that the easiest one might be `Chokidar 2` where you just have to migrate to `Chokidar 3`.
With respect to the others, I would suggest to screen the docs of the deprecated libraries where you probably can find hints for replacements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413217586
Sounds good, I'll get started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated UI dependencies (streampipes)
Posted by "azher-alnabi (via GitHub)" <gi...@apache.org>.
azher-alnabi commented on issue #1196:
URL: https://github.com/apache/streampipes/issues/1196#issuecomment-1413106723
Hey there, are you still looking for someone to remove the deprecated UI dependencies? If so, I'm willing to give it a shot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org