[GitHub] [ozone] devmadhuu commented on a diff in pull request #5203: HDDS-1796. SCMClientProtocolServer#getContainerWithPipeline should check for admin access

["devmadhuu (via GitHub)" <gi...@apache.org>]

devmadhuu commented on code in PR #5203:
URL: https://github.com/apache/ozone/pull/5203#discussion_r1317347593


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -865,6 +863,7 @@ public void transferLeadership(String newLeaderId)
 
   public List<DeletedBlocksTransactionInfo> getFailedDeletedBlockTxn(int count,
       long startTxId) throws IOException {
+    getScm().checkAdminAccess(getRemoteUser(), true);

Review Comment:
   > This check can be removed too.
   
   Done.



##########
hadoop-ozone/dist/src/main/smoketest/basic/links.robot:
##########
@@ -56,7 +56,7 @@ Verify Bucket ACL
 
 Can follow link with read access
     Execute             kdestroy
-    Run Keyword         Kinit test user             testuser2         testuser2.keytab
+    Run Keyword         Kinit test user             testuser          testuser.keytab

Review Comment:
   Yes removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org