You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2015/03/03 12:28:17 UTC
Re: Review Request 31472: stout: Make fromLinkDevice method member of
the IPNetwork class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
-----------------------------------------------------------
(Updated March 3, 2015, 11:28 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp fb98317a68986cb1228c584a8cd83b07737895a8
Diff: https://reviews.apache.org/r/31472/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31472: stout: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/#review75912
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 8:36 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31472/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 8:36 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 6fbbb4d1ae12b231d12a20e73c7bf6605c09d998
> 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp 165e29d3d2052dd5a222536e3fd111ecb4082cc2
>
> Diff: https://reviews.apache.org/r/31472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 31472: stout: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
-----------------------------------------------------------
(Updated March 10, 2015, 8:36 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 6fbbb4d1ae12b231d12a20e73c7bf6605c09d998
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp 165e29d3d2052dd5a222536e3fd111ecb4082cc2
Diff: https://reviews.apache.org/r/31472/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31472: stout: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/#review75560
-----------------------------------------------------------
Bad patch!
Reviews applied: [31472]
Failed command: ./support/apply-review.sh -n -r 31472
Error:
2015-03-06 22:55:17 URL:https://reviews.apache.org/r/31472/diff/raw/ [2540/2540] -> "31472.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:338
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp:25
error: 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 6, 2015, 7:59 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31472/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 7:59 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
> 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp fb98317a68986cb1228c584a8cd83b07737895a8
>
> Diff: https://reviews.apache.org/r/31472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 31472: stout: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
-----------------------------------------------------------
(Updated March 6, 2015, 7:59 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp fb98317a68986cb1228c584a8cd83b07737895a8
Diff: https://reviews.apache.org/r/31472/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31472: stout: Make fromLinkDevice method member of
the IPNetwork class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
-----------------------------------------------------------
(Updated March 5, 2015, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp fb98317a68986cb1228c584a8cd83b07737895a8
Diff: https://reviews.apache.org/r/31472/diff/
Testing
-------
Thanks,
Evelina Dumitrescu