You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "masahi (via GitHub)" <gi...@apache.org> on 2023/05/13 20:57:50 UTC
[GitHub] [tvm] masahi opened a new pull request, #14847: [CI] Update CPU image to install PyTorch
masahi opened a new pull request, #14847:
URL: https://github.com/apache/tvm/pull/14847
Follow up to https://github.com/apache/tvm/pull/14842 to actually update the image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yongwww commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193048746
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
cc: @driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193053980
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
According to https://tvm.apache.org/docs/contribute/ci.html#updating-a-docker-image-tag, the current protocol is to reference `tlcpack` in a PR that updates an image, and CI automatically fetches the corresponding image from `tlcpackstaging`. The images are automatically uploaded to `tlcpack` after successful merge.
I updated the account to `tlcpack`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #14847:
URL: https://github.com/apache/tvm/pull/14847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193053980
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
According to https://tvm.apache.org/docs/contribute/ci.html#updating-a-docker-image-tag, the current protocol is to reference `tlcpack` in a PR that updates an image, and CI automatically fetches from the corresponding image from `tlcpackstaging`. The images are automatically uploaded to `tlcpack` after successful merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14847:
URL: https://github.com/apache/tvm/pull/14847#issuecomment-1546748413
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @areusch, @driazati, @gigiblender, @leandron <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yongwww commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193048711
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
looks the images were uploaded into https://hub.docker.com/u/tlcpack already, we can replace tlcpackstaging with tlcpack for the images with tag 20230504-142417-4d37a0a0. Probably we can do it in follow-up pr after the cpu image with tag 20230513-200357-e54bbc73 is uploaded into tlcpack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14847:
URL: https://github.com/apache/tvm/pull/14847#issuecomment-1548433879
I don't get why we are still getting the `free(): invalid pointer` error even though I'm using `--link-static` and `-DHIDE_PRIVATE_SYMBOLS=ON`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yongwww commented on pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on PR #14847:
URL: https://github.com/apache/tvm/pull/14847#issuecomment-1548484446
Previously what I did to debug the tests related to CI changes is to reproduce it locally first, the ec2 instance type for cpu container is r5.large.
Steps to reproduce:
1). pull the docker image, and create a container from this image
2). pull the tvm code
3). build tvm (generate the same config.cmake as ci: `tests/scripts/task_config_build_cpu.sh build`), set env variables like TVM_HOME
Then the try to run the failed test, it should be reproduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yongwww commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193048711
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
looks the images were uploaded into https://hub.docker.com/u/tlcpack already, we can replace tlcpackstaging with tlcpack for the images with tag 20230504-142417-4d37a0a0. I can update it in follow-up pr after the cpu image with tag 20230513-200357-e54bbc73 is uploaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193053980
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
According to https://tvm.apache.org/docs/contribute/ci.html#updating-a-docker-image-tag, the current protocol is to reference `tlcpack` in a PR that updates an image, and CI automatically fetches the corresponding image from `tlcpackstaging`. The images are automatically uploaded to `tlcpack` after successful merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #14847: [CI] Update CPU image to install PyTorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #14847:
URL: https://github.com/apache/tvm/pull/14847#discussion_r1193036937
##########
ci/jenkins/docker-images.ini:
##########
@@ -19,7 +19,7 @@
[jenkins]
ci_arm: tlcpackstaging/ci_arm:20230504-142417-4d37a0a0
ci_cortexm: tlcpackstaging/ci_cortexm:20230504-142417-4d37a0a0
-ci_cpu: tlcpackstaging/ci_cpu:20230504-142417-4d37a0a0
+ci_cpu: tlcpackstaging/ci_cpu:20230513-200357-e54bbc73
Review Comment:
I noticed that all images are pointing to `tlcpackstaging` account rather than `tlcpack` since https://github.com/apache/tvm/pull/14651. Should we fix them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org