You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/06/28 00:47:52 UTC
[GitHub] flink pull request #4202: [FLINK-6422] [core] Unreachable code in FileInputF...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4202
[FLINK-6422] [core] Unreachable code in FileInputFormat#createInputSp…
Fix Unreachable code in FileInputFormat#createInputSplits.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6422
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4202
----
commit 4cc3e55621372eaf4a9661939f52656aeef4eeef
Author: zhangminglei <zm...@163.com>
Date: 2017-06-28T00:45:12Z
[FLINK-6422] [core] Unreachable code in FileInputFormat#createInputSplits
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4202
Can you take a look at the error in CI ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4202
Seems I could not get any useful information from CI, except for this kinda stuff following and it seems not relevant to this issue.
```
Running org.apache.flink.test.recovery.JobManagerHACheckpointRecoveryITCase
java.lang.RuntimeException: org.apache.zookeeper.server.ZooKeeperServer class is frozen
at javassist.CtClassType.checkModify(CtClassType.java:288)
at javassist.CtBehavior.setBody(CtBehavior.java:432)
at javassist.CtBehavior.setBody(CtBehavior.java:412)
at org.apache.curator.test.ByteCodeRewrite.fixMethods(ByteCodeRewrite.java:91)
at org.apache.curator.test.ByteCodeRewrite.<clinit>(ByteCodeRewrite.java:50)
at org.apache.curator.test.TestingServer.<clinit>(TestingServer.java:33)
at org.apache.flink.test.recovery.JobManagerHACheckpointRecoveryITCase.testCheckpointedStreamingProgram(JobManagerHACheckpointRecoveryITCase.java:345)
at org.apache.flink.test.recovery.JobManagerHACheckpointRecoveryITCase.testCheckpointedStreamingProgramIncrementalRocksDB(JobManagerHACheckpointRecoveryITCase.java:331)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4202
Thanks @tedyu for reporting this. cc @StephanEwen @tedyu Could both you take a look ? I checked the first version you designed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4202: [FLINK-6422] [core] Unreachable code in FileInputF...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4202
LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4202
Thanks @tzulitai for review! And thanks @tedyu for reporting this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---