You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Seungun Choe <wh...@gmail.com> on 2014/04/30 08:13:11 UTC

Review Request 20878: Implement Round(numeric, int) function.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20878/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-807
    https://issues.apache.org/jira/browse/TAJO-807


Repository: tajo


Description
-------

round to s decimal places
ex) select round(42.4382, 2); --> 42.44
select round(round(425, 2) --> 425.0


Diffs
-----

  tajo-core/src/main/java/org/apache/tajo/engine/function/math/RoundFloat.java PRE-CREATION 
  tajo-core/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java 09f7f68 

Diff: https://reviews.apache.org/r/20878/diff/


Testing
-------

mvn clean install is OK.


Thanks,

Seungun Choe


Re: Review Request 20878: Implement Round(numeric, int) function.

Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20878/#review41818
-----------------------------------------------------------


The patch looks good to me. I leaved some trivial comment.


tajo-core/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java
<https://reviews.apache.org/r/20878/#comment75443>

    Could you add more unit tests with more various round digits and additional INT8 parameter?


- Hyunsik Choi


On April 30, 2014, 3:13 p.m., Seungun Choe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20878/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 3:13 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-807
>     https://issues.apache.org/jira/browse/TAJO-807
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> round to s decimal places
> ex) select round(42.4382, 2); --> 42.44
> select round(round(425, 2) --> 425.0
> 
> 
> Diffs
> -----
> 
>   tajo-core/src/main/java/org/apache/tajo/engine/function/math/RoundFloat.java PRE-CREATION 
>   tajo-core/src/test/java/org/apache/tajo/engine/function/TestMathFunctions.java 09f7f68 
> 
> Diff: https://reviews.apache.org/r/20878/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install is OK.
> 
> 
> Thanks,
> 
> Seungun Choe
> 
>