You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2008/02/27 22:11:59 UTC

[jira] Created: (SLING-285) ujax post servlet should silently replace existing move targets

ujax post servlet should silently replace existing move targets
---------------------------------------------------------------

                 Key: SLING-285
                 URL: https://issues.apache.org/jira/browse/SLING-285
             Project: Sling
          Issue Type: Bug
          Components: microsling
            Reporter: Tobias Bocanegra


currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra closed SLING-285.
----------------------------------


thanks.

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: ujax
>            Reporter: Tobias Bocanegra
>            Assignee: Felix Meschberger
>             Fix For: 2.0.0
>
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra updated SLING-285:
-----------------------------------

    Attachment:     (was: ujax_move_fix.r631699.patch)

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: microsling
>            Reporter: Tobias Bocanegra
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573069#action_12573069 ] 

Felix Meschberger commented on SLING-285:
-----------------------------------------

Hmm, I think failure is ok if the target already exists, even in a scripting environment. Otherwise you may silently overwrite data. This should not be possible. The other problem is SNS ... 

Probably the move operation must check for the target to exist and fail with a meaningfull message.

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: microsling
>            Reporter: Tobias Bocanegra
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra updated SLING-285:
-----------------------------------

    Attachment: ujax_move_fix.r631699.patch

new patch including the check for 'replace'

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: microsling
>            Reporter: Tobias Bocanegra
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated SLING-285:
------------------------------------

      Component/s:     (was: microsling)
                   ujax
    Fix Version/s: 2.0.0

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: ujax
>            Reporter: Tobias Bocanegra
>            Assignee: Felix Meschberger
>             Fix For: 2.0.0
>
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra updated SLING-285:
-----------------------------------

    Attachment: ujax_move_fix.r631699.patch

fixes the replace.

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: microsling
>            Reporter: Tobias Bocanegra
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-285.
-------------------------------------

    Resolution: Fixed

Applied patch in Rev. 631993 and added testcases in Rev. 632004

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: ujax
>            Reporter: Tobias Bocanegra
>            Assignee: Felix Meschberger
>             Fix For: 2.0.0
>
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573076#action_12573076 ] 

Tobias Bocanegra commented on SLING-285:
----------------------------------------

maybe this can be solved using a flag:

ujax:moveFlags="replace"

which will enable this behaviour

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: microsling
>            Reporter: Tobias Bocanegra
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573317#action_12573317 ] 

fmeschbe edited comment on SLING-285 at 2/28/08 7:28 AM:
------------------------------------------------------------------

Applied patch in Rev. 631993 and added testcases in Rev. 632004

Please close this issue, if it is ok for you. Thanks.

      was (Author: fmeschbe):
    Applied patch in Rev. 631993 and added testcases in Rev. 632004
  
> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: ujax
>            Reporter: Tobias Bocanegra
>            Assignee: Felix Meschberger
>             Fix For: 2.0.0
>
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SLING-285) ujax post servlet should silently replace existing move targets

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned SLING-285:
---------------------------------------

    Assignee: Felix Meschberger

> ujax post servlet should silently replace existing move targets
> ---------------------------------------------------------------
>
>                 Key: SLING-285
>                 URL: https://issues.apache.org/jira/browse/SLING-285
>             Project: Sling
>          Issue Type: Bug
>          Components: ujax
>            Reporter: Tobias Bocanegra
>            Assignee: Felix Meschberger
>             Fix For: 2.0.0
>
>         Attachments: ujax_move_fix.r631699.patch
>
>
> currently moving a node to a new target fails (or worse: creates SNS) if the target node already exists. for convenient scripting and easier client implementation i suggest that the 'move' checks for existing targets and then removes them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.