You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/16 19:34:21 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6281: [DNM]: Verbose CI build
Ouss4 opened a new pull request, #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#issuecomment-1129117968
Ah, I ended up messing the commit message when rebasing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on code in PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#discussion_r874767512
##########
tools/ci/cibuild.sh:
##########
@@ -224,7 +224,7 @@ function xtensa-esp32-gcc-toolchain {
esac
fi
xtensa-esp32-elf-gcc --version
- pip3 install esptool
+ pip3 install esptool==3.0
Review Comment:
Thanks for catching that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#discussion_r874754724
##########
tools/ci/cibuild.sh:
##########
@@ -224,7 +224,7 @@ function xtensa-esp32-gcc-toolchain {
esac
fi
xtensa-esp32-elf-gcc --version
- pip3 install esptool
+ pip3 install esptool==3.0
Review Comment:
```suggestion
pip3 install esptool==3.3.1
```
Version 3.0 does not provide support for newer chips like **ESP32-C3** and **ESP32-S3**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6281: [DNM]: Verbose CI build
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#issuecomment-1128097215
> esptool.py not found. Please run: "pip install esptool"
Finally, the issue is that `esptool` is somehow not installed, even though we do have a`pip3 install esptool`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#issuecomment-1128665712
> Seems that "ESPTOOL V3.0" change is missing or not needed. Could you please update the commit message and PR description?
I was just trying something else to install V4. But that failed, so I restored the other change that installs V3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#issuecomment-1128664153
Seems that "ESPTOOL V3.0" change is missing or not needed. Could you please update the commit message and PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6281: cibuild.sh: Install ESPTOOL V3.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6281:
URL: https://github.com/apache/incubator-nuttx/pull/6281#issuecomment-1128661030
We're not we CI failures today, looks like phy6222 was unable to download its library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org