You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@impala.apache.org by "David Knupp (Jira)" <ji...@apache.org> on 2020/02/06 20:35:00 UTC

[jira] [Created] (IMPALA-9362) Update sqlparse used by impala-shell from version 0.1.19 to latest

David Knupp created IMPALA-9362:
-----------------------------------

             Summary: Update sqlparse used by impala-shell from version 0.1.19 to latest
                 Key: IMPALA-9362
                 URL: https://issues.apache.org/jira/browse/IMPALA-9362
             Project: IMPALA
          Issue Type: Improvement
          Components: Clients
    Affects Versions: Impala 3.4.0
            Reporter: David Knupp


The fix for IMPALA-6337 involved correcting the way that sqlparse, an upstream 3rd party python library used by the impala-shell, parses queries that contain line breaks embedded inside of double quotes. Initially, Impala's internally bundled version of sqlparse (based on 0.1.19) was patched; meanwhile, a pull request to get the fix into an official release was submitted.

That pull-request was finally included in the 0.3.0 version of sqlparse. However, there were other changes to the library in the interim, in terms of API's and also in some of the parsing logic, that breaks the impala-shell in other ways, so simply migrating to the newer release is not straightforward.

We need to find and fix all the places that the newer sqlparse breaks the impala-shell, so that we can stop relying on sqlparse 0.1.19 (which, in some places, is not python 3 compatible).






--
This message was sent by Atlassian Jira
(v8.3.4#803005)