[jira] [Commented] (MAPREDUCE-3686) history server web ui - job counter values for map/reduce not shown properly

["Bhallamudi Venkata Siva Kamesh (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191302#comment-13191302 ] 

Bhallamudi Venkata Siva Kamesh commented on MAPREDUCE-3686:
-----------------------------------------------------------

While incrementing the counters, existence of counters group has been checked in *groups* map. If not found in *groups* map, created a new group and stored the same group back in the *groups* map.

{code:title=AbstractCounters.java|borderStyle=solid}
   G left = groups.get(right.getName());
      if (left == null) {
        limits.checkGroups(groups.size() + 1);
        left = groupFactory.newGroup(right.getName(), right.getDisplayName(),
                                     limits);
        groups.put(right.getName(), left);
      }
}
{code} 

However while getting CounterGroup, if it is a framework related, getting from *fgroups* map, otherwise, from *groups* map.

{code:title=CountersBlock.java|borderStyle=solid}
boolean isFGroup = isFrameworkGroup(newGroupName);
G group = isFGroup ? fgroups.get(newGroupName) : groups.get(newGroupName);
}
{code}

I think, this is causing issue and we need to update same in AbstractCounters#incrAllCounters method as well.

Any comments?
                
> history server web ui - job counter values for map/reduce not shown properly
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3686
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3686
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Priority: Critical
>         Attachments: jobcounter1.png, jobcounter2.png
>
>
> Looking at the job counters page on the history server for a finished job, it shows 3 columns for each counter - map, reduce, total. The total appears correct, but map and reduce columns are always zero.  If you click on a particular column it does show you the map/reduce task and the value of each one.
> Going to attach screenshots shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira