You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/20 14:46:58 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #7521: Support real equalMatch in OAL core
wu-sheng opened a new issue #7521:
URL: https://github.com/apache/skywalking/issues/7521
### Discussed in https://github.com/apache/skywalking/discussions/7517
<div type='discussions-op-text'>
<sup>Originally posted by **807801002** August 20, 2021</sup>
Which field can be used at filter()？I thought all fields in org.apache.skywalking.oap.server.core.source.ServiceRelation can be used to the filter expression for "from(ServiceRelation.*)".But the "componentId == 7" is error. which is a field at ServiceRelation.
</div>
We have `EqualMatch`(function name, `stringMatch`), but this is for String type only. We should add a real `equalMatch` function in grammar tree and implementation in `org.apache.skywalking.oap.server.core.analysis.metrics.expression`.
Also, we should rename class `EqualMatch` to `StringMatch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7521:
URL: https://github.com/apache/skywalking/issues/7521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] YczYanchengzhe commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
YczYanchengzhe commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-909368809
I want to implement this by adding intmatch and wonder if it assign assigned to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-909371865
@YczYanchengzhe assigned, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] YczYanchengzhe commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
YczYanchengzhe commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-910211432
I encountered a problem.
After I completed the development and passed the unit test, I wanted to run the integration and found this error. The cause of the error was that the oal.core included parameter configuration could not be recognized. What could be the reason for this?
line 23:46 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 24:42 mismatched input '100' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 30:54 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 40:120 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 41:120 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 50:137 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 51:137 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 62:56 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 68:118 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 73:69 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-909371865
@YczYanchengzhe assigned, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] YczYanchengzhe commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
YczYanchengzhe commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-909368809
I want to implement this by adding intmatch and wonder if it assign assigned to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-910213655
You should change antlr file, and oal core to generate correct class codes. I am feeling you don't change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] YczYanchengzhe commented on issue #7521: Support real equalMatch in OAL core
Posted by GitBox <gi...@apache.org>.
YczYanchengzhe commented on issue #7521:
URL: https://github.com/apache/skywalking/issues/7521#issuecomment-910211994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org