[jira] [Comment Edited] (WAGON-518) AbstractHttpClientWagon#putFromStream() reads entire content to memory

["Chris Lott (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WAGON-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449870#comment-16449870 ] 

Chris Lott edited comment on WAGON-518 at 4/24/18 1:43 PM:
-----------------------------------------------------------

I cloned, switched to branch WAGON-518, ran mvn install, changed my code to use version 3.1.0-SNAPSHOT, built mine and the tests revealed no errors. Not tested with Maven.  HTH


was (Author: chrislott):
I cloned, ran mvn install, changed my code to use version 3.1.0-SNAPSHOT, built mine and the tests revealed no errors. Not tested with Maven.  HTH

> AbstractHttpClientWagon#putFromStream() reads entire content to memory
> ----------------------------------------------------------------------
>
>                 Key: WAGON-518
>                 URL: https://issues.apache.org/jira/browse/WAGON-518
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 2.12
>            Reporter: Chris Lott
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.1.0
>
>
> Method putFromSteam in class AbstractHttpClientWagon seems to violate the implied contract of working with streams.  It uses much memory because it first consumes the input stream argument, then transfers that content.  The code that consumes the stream is in the private class RequestEntityImplementation ctor:
> {code:java}
>      byte[] bytes = IOUtil.toByteArray( stream );{code}
> Please revise it, if possible, to behave more like the superclass StreamWagon's putFromStream method, which does the transfer straight from the input stream.
> We are attempting to PUT some 150MB artifacts in a java microservice that runs with rather sharp memory limits.  As a local workaround we increased the JVM's -Xmx argument but that way lies madness.
> Thanks in advance for any suggestions or workarounds. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)