[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #9143: IGNITE-14808 RIGHT|FULL Join operations are lost nulls sort ordering.

[GitBox <gi...@apache.org>]

tledkov-gridgain commented on a change in pull request #9143:
URL: https://github.com/apache/ignite/pull/9143#discussion_r687567800



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java
##########
@@ -247,8 +248,11 @@ private static Object affinityIdentity(CacheConfiguration<?, ?> ccfg) {
             boolean descending = idxDesc.descending(idxField);
             int fieldIdx = fieldDesc.fieldIndex();
 
-            RelFieldCollation collation = new RelFieldCollation(fieldIdx,
-                descending ? RelFieldCollation.Direction.DESCENDING : RelFieldCollation.Direction.ASCENDING);
+            RelFieldCollation collation = new RelFieldCollation(
+                fieldIdx,
+                descending ? RelFieldCollation.Direction.DESCENDING : RelFieldCollation.Direction.ASCENDING,
+                RelFieldCollation.NullDirection.FIRST

Review comment:
       Is the `NullDirection.FIRST` applicable both for ASC & DESC orders?
   Maybe we have to use inverse of the `RelFieldCollation.Direction.defaultNullDirection()` or our own implementation of such method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org