You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/07 02:39:42 UTC

[jira] [Commented] (ZOOKEEPER-2729) Cleanup findbug warnings in branch-3.4: Correctness Warnings

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960192#comment-15960192 ] 

ASF GitHub Bot commented on ZOOKEEPER-2729:
-------------------------------------------

GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/220

    ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4: Correctness Warnings

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----
commit a2a0a9840d271ab6c3151f8b4917dfa0b3c72a8a
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-07T02:38:26Z

    ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4: Correctness Warnings

----


> Cleanup findbug warnings in branch-3.4: Correctness Warnings
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2729
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2729
>             Project: ZooKeeper
>          Issue Type: Sub-task
>    Affects Versions: 3.4.9
>            Reporter: Rakesh R
>            Assignee: Abraham Fine
>             Fix For: 3.4.11
>
>
> {code}
> (1) INT Bad comparison of nonnegative value with 0 in org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream, byte[])
> Bug type INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE (click for details) 
> In class org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner
> In method org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream, byte[])
> Value 0
> At SaslQuorumAuthLearner.java:[line 176]
> (2) INT	Bad comparison of nonnegative value with 0 in org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream, byte[], QuorumAuth$Status)
> Bug type INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE (click for details) 
> In class org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer
> In method org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream, byte[], QuorumAuth$Status)
> Value 0
> At SaslQuorumAuthServer.java:[line 170]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)