You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/06/05 07:51:50 UTC

[GitHub] theit commented on a change in pull request #55: Fix for SCM-805

theit commented on a change in pull request #55: Fix for SCM-805
URL: https://github.com/apache/maven-scm/pull/55#discussion_r192977649
 
 

 ##########
 File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java
 ##########
 @@ -34,11 +34,14 @@
 
     private boolean remoteBranching = false;
 
+    private boolean pinExternals = false;
 
 Review comment:
   What about the following scenario:
   You create a branch for a release version to be able to do special release hotfixes. The externals refer to a different project's trunk that is developed / restructured / whatever in a way that is incompatible with your actual release.
   Without pinned externals, your branch won't work anymore.
   
   In that case, yes I think it's useful / necessary to be able to pin externals even in branches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services