You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/09 07:12:55 UTC

[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4739: [Fix-4738][Mail] Fix send mail failed instead of execute sql error

chengshiwen commented on pull request #4739:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4739#issuecomment-775725337


   Please think about this as a regular user, not a developer.
   Why must the sql task be bound to mail? Why must the query result be sent by mail when executing the SELECT statement? Can the sql task be executed without mail?
   Both executing SQL and sending mail are independent. Even with the `Query` type, sending mail should be optional. But it is required now, it's reasonable and minimal cost to catch the `send mail failed` exception.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org