[GitHub] [airflow] potiuk edited a comment on pull request #17502: localize the dag_run

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-895124301


   @uranusjr wrota about adding unit tests. 
   
   And also there is one serious caveat (and one that should be covered by the unit tests) as well for sure is the DST change. UTC is not only easy to implement but guarantees conflict avoidance. With local time, if you have hourly scheduled DAG, you have a guaranteed conflict once a year - you will get the same run id conflict (when you move clock backwards). So unless you make sure that timezone is included and reflected properly, you might have a problem. 
   
   I think in this case, the time zone offset will be different when you use isoformat, but it definitely need testing (and what I mean by that unit testing) - so that we can avoid regressions and you actually have shown that you thought and tested that case consciously. 
   
   Also i think it would be great to have parameterized unit 
   test with a number of more or less probable and 'weird' timezones. There are certain timezones (with half or even quarter-hour shifts) so it would.be great to see those tested as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org