You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/09 17:14:16 UTC
[GitHub] [airflow] rayrrr opened a new pull request #7116: [AIRFLOW-5167]
Rolling dependencies for GCP
rayrrr opened a new pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116
As a potential fix to https://issues.apache.org/jira/browse/AIRFLOW-5167 this commit changes outdated hard-pinned dependencies to rolling dependencies.
While both pinned and rolling have their pros and cons, in this situation, it might be best to just deal with the bugs from rolling breaking changes as they pop up.
Alternately, we should re-pin from time to time with totally hard-pinned deps. What we currently have here is a mix, so it should change one way or the other.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365042953
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
This should probably stay as it is otherwise, when 1.0 of `httplib2` will be released, it might break things
`httplib2~=0.9` means `httplib2>=0.9,==0.9.*`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7116: [AIRFLOW-5167] Rolling
dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] rayrrr commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
rayrrr commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365047837
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
Hi @kaxil, the `~=` seems like a reasonable exception to the rule from time to time in both rolling and hard-pinned contexts. My conflict-free set of hard-pinned requirements actually has `httplib==0.15.0` so would you approve of upping this to `httplib2~=0.15`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365042953
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
This should probably stay as it is otherwise, when 1.0 of `httplib2` will be released, it might break things
`httplib2~=0.9` means `httplib2>=0.9,==0.*` ~`httplib2>=0.9,==0.9.*`~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] rayrrr commented on issue #7116: [AIRFLOW-5167] Rolling
dependencies for GCP
Posted by GitBox <gi...@apache.org>.
rayrrr commented on issue #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#issuecomment-573061540
Thanks for the quick review and merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365042953
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
This should probably stay as it is otherwise, when 1.0 of `httplib2` will be released, it might break things
'httplib2~=0.9' means 'httplib2>=0.9,==0.9.*'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#issuecomment-573061159
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#issuecomment-573060906
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=h1) Report
> Merging [#7116](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c880221d76cf21c86ecdd24d1d423b78d6ceb32d?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7116 +/- ##
==========================================
- Coverage 85.23% 84.96% -0.27%
==========================================
Files 682 683 +1
Lines 39045 39155 +110
==========================================
- Hits 33280 33269 -11
- Misses 5765 5886 +121
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.04% <0%> (-20.71%)` | :arrow_down: |
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <0%> (-0.69%)` | :arrow_down: |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <0%> (-0.44%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.07% <0%> (-0.13%)` | :arrow_down: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.86% <0%> (-0.03%)` | :arrow_down: |
| [airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5) | `99.29% <0%> (-0.01%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=footer). Last update [c880221...92e7e25](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365217109
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
Sorry @rayrrr It was a typo from my end.
`httplib2~=0.9` means `httplib2>=0.9,==0.*` (not `httplib2>=0.9,==0.9.*`)
So it would install the latest package that is `<1.0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365217362
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
Also, I am fine with upping it to `httplib2~=0.15` :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] rayrrr commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
rayrrr commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365047837
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
Hi @kaxil, the `~=` seems like a reasonable exception from time to time in both rolling and hard-pinned contexts. My conflict-free set of hard-pinned requirements actually has `httplib==0.15.0` so would you approve of upping this to `httplib2~=0.15`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7116: [AIRFLOW-5167]
Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#issuecomment-573060906
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=h1) Report
> Merging [#7116](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c880221d76cf21c86ecdd24d1d423b78d6ceb32d?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7116 +/- ##
==========================================
- Coverage 85.23% 84.96% -0.27%
==========================================
Files 682 683 +1
Lines 39045 39155 +110
==========================================
- Hits 33280 33269 -11
- Misses 5765 5886 +121
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.04% <0%> (-20.71%)` | :arrow_down: |
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <0%> (-0.69%)` | :arrow_down: |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <0%> (-0.44%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.07% <0%> (-0.13%)` | :arrow_down: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.86% <0%> (-0.03%)` | :arrow_down: |
| [airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5) | `99.29% <0%> (-0.01%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/airflow/pull/7116/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=footer). Last update [c880221...92e7e25](https://codecov.io/gh/apache/airflow/pull/7116?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] rayrrr commented on a change in pull request #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
rayrrr commented on a change in pull request #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#discussion_r365244107
##########
File path: setup.py
##########
@@ -218,24 +218,24 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-auth-httplib2>=0.0.1',
'google-cloud-automl>=0.4.0',
'google-cloud-bigquery-datatransfer>=0.4.0',
- 'google-cloud-bigtable==1.0.0',
+ 'google-cloud-bigtable>=1.0.0',
'google-cloud-container>=0.1.1',
- 'google-cloud-dataproc==0.5.0',
+ 'google-cloud-dataproc>=0.5.0',
'google-cloud-dlp>=0.11.0',
'google-cloud-kms>=1.2.1',
'google-cloud-language>=1.1.1',
- 'google-cloud-pubsub==1.0.0',
+ 'google-cloud-pubsub>=1.0.0',
'google-cloud-redis>=0.3.0',
'google-cloud-spanner>=1.10.0',
'google-cloud-speech>=0.36.3',
- 'google-cloud-storage~=1.16',
- 'google-cloud-tasks==1.2.1',
+ 'google-cloud-storage>=1.16',
+ 'google-cloud-tasks>=1.2.1',
'google-cloud-texttospeech>=0.4.0',
'google-cloud-translate>=1.5.0',
'google-cloud-videointelligence>=1.7.0',
'google-cloud-vision>=0.35.2',
'grpcio-gcp>=0.2.2',
- 'httplib2~=0.9',
+ 'httplib2>=0.9',
Review comment:
@kaxil done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7116:
[AIRFLOW-5167] Rolling dependencies for GCP
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#issuecomment-572661659
Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
Adding a new operator? Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from
Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7116: [AIRFLOW-5167] Rolling
dependencies for GCP
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7116: [AIRFLOW-5167] Rolling dependencies for GCP
URL: https://github.com/apache/airflow/pull/7116#issuecomment-573061730
> Thanks for the quick review and merge!
No problem. Thanks for the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services