You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by matthieumorel <gi...@git.apache.org> on 2015/01/27 14:06:23 UTC
[GitHub] incubator-samoa pull request: SAMOA-6 : code formatting
GitHub user matthieumorel opened a pull request:
https://github.com/apache/incubator-samoa/pull/2
SAMOA-6 : code formatting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matthieumorel/incubator-samoa SAMOA-6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-samoa/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 5af84c1b04a6445449019f9295f91f1002b8a1c3
Author: Matthieu Morel <mm...@apache.org>
Date: 2015-01-27T12:54:57Z
Add eclipse formatting reference file
commit 23a35dbeb6c991b66293cc8138313b7651c831a2
Author: Matthieu Morel <mm...@apache.org>
Date: 2015-01-27T12:56:17Z
Format java source files according to the eclipse-format.xml standard
- spaces, no tabs
- indent size = 2 spaces
- line wrap at 120
commit 6539c9138d33993551b0a6738784da6eda7b6b84
Author: Matthieu Morel <mm...@apache.org>
Date: 2015-01-27T12:57:24Z
Properly indent xml files. Indentation set to 2 spaces.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-6 : code formatting
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh commented on the pull request:
https://github.com/apache/incubator-samoa/pull/2#issuecomment-72670770
Testing JIRA integration, ignore this please :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-6 : code formatting
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-samoa/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-6 : code formatting
Posted by matthieumorel <gi...@git.apache.org>.
Github user matthieumorel commented on the pull request:
https://github.com/apache/incubator-samoa/pull/2#issuecomment-72830764
@gdfm : the EOL issue is related to carrier return characters, and was not introduced in this patch. Usually these characters are introduced when importing from windows/dos.
Anyway, I'm fixing this file as it's the only one affected in the repo:
find . |xargs file | grep CRLF
./samoa-api/src/main/java/com/yahoo/labs/samoa/moa/classifiers/core/attributeclassobservers/BinaryTreeNumericAttributeClassObserverRegression.java: ASCII c program text, with CRLF line terminators`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---