[GitHub] [incubator-openwhisk-runtime-go] sciabarracom commented on a change in pull request #97: env support

[GitBox <gi...@apache.org>]

sciabarracom commented on a change in pull request #97: env support
URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/97#discussion_r305572214
 
 

 ##########
 File path: openwhisk/executor.go
 ##########
 @@ -44,13 +44,16 @@ type Executor struct {
 // NewExecutor creates a child subprocess using the provided command line,
 // writing the logs in the given file.
 // You can then start it getting a communication channel
-func NewExecutor(logout *os.File, logerr *os.File, command string, args ...string) (proc *Executor) {
+func NewExecutor(logout *os.File, logerr *os.File, command string, env map[string]string, args ...string) (proc *Executor) {
 	cmd := exec.Command(command, args...)
 	cmd.Stdout = logout
 	cmd.Stderr = logerr
 	cmd.Env = []string{
 
 Review comment:
   if it is already in the Env map, then no...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services