You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Maxim Solodovnik <so...@gmail.com> on 2018/10/03 08:23:19 UTC

Re: Code clean-up questions

OK
seems to be done :)

According to Maven following plugins/dependencies can be updated:
[INFO]   com.sun.xml.bind:jaxb-impl ............... 2.2.1 ->
2.4.0-b180830.0438
[INFO]   javax.xml.bind:jaxb-api .................. 2.2.1 ->
2.4.0-b180830.0359
[INFO]   org.apache.ant:ant ................................... 1.9.7 ->
1.10.5
[INFO]   org.apache.derby:derby ........................ 10.12.1.1 ->
10.14.2.0
[INFO]   org.jmock:jmock ....................................... 2.8.2 ->
2.9.0
[INFO]   org.jmock:jmock-junit4 ................................ 2.8.2 ->
2.9.0
[INFO]   org.slf4j:slf4j-api ............................ 1.7.21 ->
1.8.0-beta2
[INFO]
[INFO] The following dependencies in pluginManagement of plugins have newer
versions:
[INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
20020829
[INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
1.10.5
[INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2 ->
1.8
[INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5 ->
1.2
[INFO]
[INFO] The following dependencies in Plugin Dependencies have newer
versions:
[INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
20020829
[INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
1.10.5
[INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2 ->
1.8
[INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5 ->
1.2


Additionally according to [1]
com.sun.xml.bind:* is actually the old name and is currently a repackaging
of org.glassfish.jaxb:*. probably kept as a retro compatibility

I can update those as well
Should I proceed?

[1] https://issues.apache.org/jira/browse/TIKA-2743

On Thu, 27 Sep 2018 at 13:27, Francesco Chicchiriccò <il...@apache.org>
wrote:

> On 27/09/2018 07:25, Maxim Solodovnik wrote:
> > Hello All,
> >
> > I have created https://issues.apache.org/jira/browse/OPENJPA-2751 and
> > listed all improvements I would like to commit
> >
> > Could you please review proposed changes?
> > I'm going to commit directly to trunk if there will be no objections,
> since
> > it make no sense to review changes like this
>
>
> Huge +1 please go ahead :-)
> Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>

-- 
WBR
Maxim aka solomax

Re: Code clean-up questions

Posted by Maxim Solodovnik <so...@gmail.com>.
Hello All,

could you please review this https://github.com/apache/openjpa/pull/23 PR?
On Wed, 3 Oct 2018 at 15:40, Maxim Solodovnik <so...@gmail.com> wrote:
>
> OK, will not touch jaxb :)
> Will create JIRA for this :)
>
> On Wed, 3 Oct 2018 at 15:37, Romain Manni-Bucau <rm...@gmail.com> wrote:
>>
>> Please don't for jaxb at least
>>
>> long story short 2.3 had several regression and 2.4 is not yet final AFAIK,
>> think we should keep having it as "provided" in a working version. CXF
>> still uses 2.2.11 for that reason AFAIK
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>>
>> Le mer. 3 oct. 2018 à 10:23, Maxim Solodovnik <so...@gmail.com> a
>> écrit :
>>
>> > OK
>> > seems to be done :)
>> >
>> > According to Maven following plugins/dependencies can be updated:
>> > [INFO]   com.sun.xml.bind:jaxb-impl ............... 2.2.1 ->
>> > 2.4.0-b180830.0438
>> > [INFO]   javax.xml.bind:jaxb-api .................. 2.2.1 ->
>> > 2.4.0-b180830.0359
>> > [INFO]   org.apache.ant:ant ................................... 1.9.7 ->
>> > 1.10.5
>> > [INFO]   org.apache.derby:derby ........................ 10.12.1.1 ->
>> > 10.14.2.0
>> > [INFO]   org.jmock:jmock ....................................... 2.8.2 ->
>> > 2.9.0
>> > [INFO]   org.jmock:jmock-junit4 ................................ 2.8.2 ->
>> > 2.9.0
>> > [INFO]   org.slf4j:slf4j-api ............................ 1.7.21 ->
>> > 1.8.0-beta2
>> > [INFO]
>> > [INFO] The following dependencies in pluginManagement of plugins have newer
>> > versions:
>> > [INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
>> > 20020829
>> > [INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
>> > 1.10.5
>> > [INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2 ->
>> > 1.8
>> > [INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5 ->
>> > 1.2
>> > [INFO]
>> > [INFO] The following dependencies in Plugin Dependencies have newer
>> > versions:
>> > [INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
>> > 20020829
>> > [INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
>> > 1.10.5
>> > [INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2 ->
>> > 1.8
>> > [INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5 ->
>> > 1.2
>> >
>> >
>> > Additionally according to [1]
>> > com.sun.xml.bind:* is actually the old name and is currently a repackaging
>> > of org.glassfish.jaxb:*. probably kept as a retro compatibility
>> >
>> > I can update those as well
>> > Should I proceed?
>> >
>> > [1] https://issues.apache.org/jira/browse/TIKA-2743
>> >
>> > On Thu, 27 Sep 2018 at 13:27, Francesco Chicchiriccò <il...@apache.org>
>> > wrote:
>> >
>> > > On 27/09/2018 07:25, Maxim Solodovnik wrote:
>> > > > Hello All,
>> > > >
>> > > > I have created https://issues.apache.org/jira/browse/OPENJPA-2751 and
>> > > > listed all improvements I would like to commit
>> > > >
>> > > > Could you please review proposed changes?
>> > > > I'm going to commit directly to trunk if there will be no objections,
>> > > since
>> > > > it make no sense to review changes like this
>> > >
>> > >
>> > > Huge +1 please go ahead :-)
>> > > Regards.
>> > >
>> > > --
>> > > Francesco Chicchiriccò
>> > >
>> > > Tirasa - Open Source Excellence
>> > > http://www.tirasa.net/
>> > >
>> > > Member at The Apache Software Foundation
>> > > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
>> > > http://home.apache.org/~ilgrosso/
>> > >
>> > >
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>> >
>
>
>
> --
> WBR
> Maxim aka solomax



-- 
WBR
Maxim aka solomax

Re: Code clean-up questions

Posted by Maxim Solodovnik <so...@gmail.com>.
OK, will not touch jaxb :)
Will create JIRA for this :)

On Wed, 3 Oct 2018 at 15:37, Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Please don't for jaxb at least
>
> long story short 2.3 had several regression and 2.4 is not yet final AFAIK,
> think we should keep having it as "provided" in a working version. CXF
> still uses 2.2.11 for that reason AFAIK
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le mer. 3 oct. 2018 à 10:23, Maxim Solodovnik <so...@gmail.com> a
> écrit :
>
> > OK
> > seems to be done :)
> >
> > According to Maven following plugins/dependencies can be updated:
> > [INFO]   com.sun.xml.bind:jaxb-impl ............... 2.2.1 ->
> > 2.4.0-b180830.0438
> > [INFO]   javax.xml.bind:jaxb-api .................. 2.2.1 ->
> > 2.4.0-b180830.0359
> > [INFO]   org.apache.ant:ant ................................... 1.9.7 ->
> > 1.10.5
> > [INFO]   org.apache.derby:derby ........................ 10.12.1.1 ->
> > 10.14.2.0
> > [INFO]   org.jmock:jmock ....................................... 2.8.2 ->
> > 2.9.0
> > [INFO]   org.jmock:jmock-junit4 ................................ 2.8.2 ->
> > 2.9.0
> > [INFO]   org.slf4j:slf4j-api ............................ 1.7.21 ->
> > 1.8.0-beta2
> > [INFO]
> > [INFO] The following dependencies in pluginManagement of plugins have
> newer
> > versions:
> > [INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
> > 20020829
> > [INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
> > 1.10.5
> > [INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2
> ->
> > 1.8
> > [INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5
> ->
> > 1.2
> > [INFO]
> > [INFO] The following dependencies in Plugin Dependencies have newer
> > versions:
> > [INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
> > 20020829
> > [INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
> > 1.10.5
> > [INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2
> ->
> > 1.8
> > [INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5
> ->
> > 1.2
> >
> >
> > Additionally according to [1]
> > com.sun.xml.bind:* is actually the old name and is currently a
> repackaging
> > of org.glassfish.jaxb:*. probably kept as a retro compatibility
> >
> > I can update those as well
> > Should I proceed?
> >
> > [1] https://issues.apache.org/jira/browse/TIKA-2743
> >
> > On Thu, 27 Sep 2018 at 13:27, Francesco Chicchiriccò <
> ilgrosso@apache.org>
> > wrote:
> >
> > > On 27/09/2018 07:25, Maxim Solodovnik wrote:
> > > > Hello All,
> > > >
> > > > I have created https://issues.apache.org/jira/browse/OPENJPA-2751
> and
> > > > listed all improvements I would like to commit
> > > >
> > > > Could you please review proposed changes?
> > > > I'm going to commit directly to trunk if there will be no objections,
> > > since
> > > > it make no sense to review changes like this
> > >
> > >
> > > Huge +1 please go ahead :-)
> > > Regards.
> > >
> > > --
> > > Francesco Chicchiriccò
> > >
> > > Tirasa - Open Source Excellence
> > > http://www.tirasa.net/
> > >
> > > Member at The Apache Software Foundation
> > > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> > > http://home.apache.org/~ilgrosso/
> > >
> > >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>


-- 
WBR
Maxim aka solomax

Re: Code clean-up questions

Posted by Romain Manni-Bucau <rm...@gmail.com>.
Please don't for jaxb at least

long story short 2.3 had several regression and 2.4 is not yet final AFAIK,
think we should keep having it as "provided" in a working version. CXF
still uses 2.2.11 for that reason AFAIK

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 3 oct. 2018 à 10:23, Maxim Solodovnik <so...@gmail.com> a
écrit :

> OK
> seems to be done :)
>
> According to Maven following plugins/dependencies can be updated:
> [INFO]   com.sun.xml.bind:jaxb-impl ............... 2.2.1 ->
> 2.4.0-b180830.0438
> [INFO]   javax.xml.bind:jaxb-api .................. 2.2.1 ->
> 2.4.0-b180830.0359
> [INFO]   org.apache.ant:ant ................................... 1.9.7 ->
> 1.10.5
> [INFO]   org.apache.derby:derby ........................ 10.12.1.1 ->
> 10.14.2.0
> [INFO]   org.jmock:jmock ....................................... 2.8.2 ->
> 2.9.0
> [INFO]   org.jmock:jmock-junit4 ................................ 2.8.2 ->
> 2.9.0
> [INFO]   org.slf4j:slf4j-api ............................ 1.7.21 ->
> 1.8.0-beta2
> [INFO]
> [INFO] The following dependencies in pluginManagement of plugins have newer
> versions:
> [INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
> 20020829
> [INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
> 1.10.5
> [INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2 ->
> 1.8
> [INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5 ->
> 1.2
> [INFO]
> [INFO] The following dependencies in Plugin Dependencies have newer
> versions:
> [INFO]   ant-contrib:ant-contrib ............................ 1.0b3 ->
> 20020829
> [INFO]   org.apache.ant:ant-jsch .............................. 1.7.1 ->
> 1.10.5
> [INFO]   org.apache.maven.doxia:doxia-core ......................... 1.2 ->
> 1.8
> [INFO]   org.codehaus.plexus:plexus-velocity ..................... 1.1.5 ->
> 1.2
>
>
> Additionally according to [1]
> com.sun.xml.bind:* is actually the old name and is currently a repackaging
> of org.glassfish.jaxb:*. probably kept as a retro compatibility
>
> I can update those as well
> Should I proceed?
>
> [1] https://issues.apache.org/jira/browse/TIKA-2743
>
> On Thu, 27 Sep 2018 at 13:27, Francesco Chicchiriccò <il...@apache.org>
> wrote:
>
> > On 27/09/2018 07:25, Maxim Solodovnik wrote:
> > > Hello All,
> > >
> > > I have created https://issues.apache.org/jira/browse/OPENJPA-2751 and
> > > listed all improvements I would like to commit
> > >
> > > Could you please review proposed changes?
> > > I'm going to commit directly to trunk if there will be no objections,
> > since
> > > it make no sense to review changes like this
> >
> >
> > Huge +1 please go ahead :-)
> > Regards.
> >
> > --
> > Francesco Chicchiriccò
> >
> > Tirasa - Open Source Excellence
> > http://www.tirasa.net/
> >
> > Member at The Apache Software Foundation
> > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> > http://home.apache.org/~ilgrosso/
> >
> >
>
> --
> WBR
> Maxim aka solomax
>