You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wangnian94 (GitHub)" <gi...@apache.org> on 2019/03/18 01:51:08 UTC
[GitHub] [incubator-dubbo] wangnian94 opened pull request #3683:
2.7.1 release
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3683 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3683: 2.7.1
release
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Please do not do things like this. After the 2.7.1-release is released, the release manager will merge it into master branch. I am closing this pull request for now.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3683 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 closed pull request #3683: 2.7.1
release
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
[ pull request closed by ralf0131 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3683 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3683: 2.7.1
release
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=h1) Report
> Merging [#3683](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b2bfbc76d13106a3211f5af1713ba50848560060?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `31.12%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3683 +/- ##
============================================
- Coverage 63.44% 63.17% -0.27%
Complexity 71 71
============================================
Files 703 704 +1
Lines 31000 31069 +69
Branches 5024 5024
============================================
- Hits 19669 19629 -40
- Misses 9066 9151 +85
- Partials 2265 2289 +24
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...gcenter/support/etcd/EtcdDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWdjZW50ZXIvc3VwcG9ydC9ldGNkL0V0Y2REeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...onfigcenter/consul/ConsulDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9jb25zdWwvQ29uc3VsRHluYW1pY0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../support/etcd/EtcdDynamicConfigurationFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWdjZW50ZXIvc3VwcG9ydC9ldGNkL0V0Y2REeW5hbWljQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L2V0Y2QvRXRjZFJlZ2lzdHJ5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1NlcnZpY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `82.48% <100%> (+1.18%)` | `0 <0> (ø)` | :arrow_down: |
| [...ontext/annotation/DubboConfigBindingRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQmluZGluZ1JlZ2lzdHJhci5qYXZh) | `93.1% <100%> (+0.37%)` | `0 <0> (ø)` | :arrow_down: |
| [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [47 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=footer). Last update [b2bfbc7...bc67770](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3683 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3683: 2.7.1
release
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=h1) Report
> Merging [#3683](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b2bfbc76d13106a3211f5af1713ba50848560060?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `31.12%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3683 +/- ##
============================================
- Coverage 63.44% 63.37% -0.08%
Complexity 71 71
============================================
Files 703 704 +1
Lines 31000 31069 +69
Branches 5024 5039 +15
============================================
+ Hits 19669 19690 +21
- Misses 9066 9103 +37
- Partials 2265 2276 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...gcenter/support/etcd/EtcdDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWdjZW50ZXIvc3VwcG9ydC9ldGNkL0V0Y2REeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...onfigcenter/consul/ConsulDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9jb25zdWwvQ29uc3VsRHluYW1pY0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../support/etcd/EtcdDynamicConfigurationFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWdjZW50ZXIvc3VwcG9ydC9ldGNkL0V0Y2REeW5hbWljQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L2V0Y2QvRXRjZFJlZ2lzdHJ5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1NlcnZpY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `82.48% <100%> (+1.18%)` | `0 <0> (ø)` | :arrow_down: |
| [...ontext/annotation/DubboConfigBindingRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQmluZGluZ1JlZ2lzdHJhci5qYXZh) | `93.1% <100%> (+0.37%)` | `0 <0> (ø)` | :arrow_down: |
| [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3683/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=footer). Last update [b2bfbc7...9941995](https://codecov.io/gh/apache/incubator-dubbo/pull/3683?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3683 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org