[jira] [Commented] (FLUME-1840) here-doc syntax of saveVersion.sh breaks on FreeBSD

["Hari Shreedharan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553144#comment-13553144 ] 

Hari Shreedharan commented on FLUME-1840:
-----------------------------------------

Jeff:

Could you please post this one as a patch file, so we can directly apply it and test it. Also, most devs here do not use BSD, so I am not sure if anyone could test this on BSD before committing.
                
> here-doc syntax of saveVersion.sh breaks on FreeBSD
> ---------------------------------------------------
>
>                 Key: FLUME-1840
>                 URL: https://issues.apache.org/jira/browse/FLUME-1840
>             Project: Flume
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: v1.3.1
>         Environment: FreeBSD 8
>            Reporter: Jeff Bachtel
>            Priority: Minor
>              Labels: patch
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Building FLUME as retrieved from git, failed during compile on FreeBSD 8. The cause turned out to be the here-doc syntax being slightly off on saveVersion.sh . Possibly the BSD shell is being more strict on syntax.
> Throwing the trivial patch in here, vice a pull req:
> diff --git a/flume-ng-core/scripts/saveVersion.sh b/flume-ng-core/scripts/saveVersion.sh
> index ad3f8b1..82666cd 100755
> --- a/flume-ng-core/scripts/saveVersion.sh
> +++ b/flume-ng-core/scripts/saveVersion.sh
> @@ -54,7 +54,7 @@ else
>  fi
>  
>  mkdir -p $buildDirectory/generated-sources/java/org/apache/flume/
> -cat << EOF | \
> +cat <<EOF | \
>    sed -e "s/VERSION/$version/" -e "s/USER/$user/" -e "s/DATE/$date/" \
>        -e "s|URL|$url|" -e "s/REV/$revision/" \
>        -e "s|BRANCH|$branch|" -e "s/SRCCHECKSUM/$srcChecksum/" \
> @@ -66,4 +66,4 @@ cat << EOF | \
>                           user="USER", date="DATE", url="URL",
>                           srcChecksum="SRCCHECKSUM")
>  package org.apache.flume;
> -EOF
> \ No newline at end of file
> +EOF

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira