You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/06/07 17:40:58 UTC
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13560
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
This patch fixes the bug TestLineage::test_create_table_timestamp where
it uses the same lineage log directory created by
TestLineage::test_start_end_timestamp, which could fail the query ID
assertion. The fix is to a different lineage log directory than the one
used by TestLineage::test_start_end_timestamp.
Testing:
- Ran test_lineage.py multiple times and it still passed.
Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
---
M tests/custom_cluster/test_lineage.py
1 file changed, 11 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/13560/2
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4429/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 17:48:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:23:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Thanks for the quick fix! LGTM, only saw one nit.
http://gerrit.cloudera.org:8080/#/c/13560/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13560/2//COMMIT_MSG@12
PS2, Line 12: to a
missing word
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 17:43:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
This patch fixes the bug TestLineage::test_create_table_timestamp where
it uses the same lineage log directory created by
TestLineage::test_start_end_timestamp, which could fail the query ID
assertion. The fix is to use a different lineage log directory than the
one used by TestLineage::test_start_end_timestamp.
Testing:
- Ran test_lineage.py multiple times and it still passed.
Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Reviewed-on: http://gerrit.cloudera.org:8080/13560
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_lineage.py
1 file changed, 11 insertions(+), 15 deletions(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3539/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 18:21:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Carry Lars' +2.
http://gerrit.cloudera.org:8080/#/c/13560/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13560/2//COMMIT_MSG@12
PS2, Line 12: to u
> missing word
Done
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 17:48:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
This patch fixes the bug TestLineage::test_create_table_timestamp where
it uses the same lineage log directory created by
TestLineage::test_start_end_timestamp, which could fail the query ID
assertion. The fix is to use a different lineage log directory than the
one used by TestLineage::test_start_end_timestamp.
Testing:
- Ran test_lineage.py multiple times and it still passed.
Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
---
M tests/custom_cluster/test_lineage.py
1 file changed, 11 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/13560/3
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8638: Fix flaky TestLineage::test create table timestamp
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13560 )
Change subject: IMPALA-8638: Fix flaky TestLineage::test_create_table_timestamp
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3540/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5813e4a570c181ba196b9ddf0210c8a0d92e21e8
Gerrit-Change-Number: 13560
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 18:28:47 +0000
Gerrit-HasComments: No