Re: Review Request 71205: Switched commit hooks to pre-commit.

[James Peach <jp...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217266
-----------------------------------------------------------


Ship it!




The pre-commit install was a bit non-obvious to me, I needed to do `sudo python3 -m pip install pre-commit`. that's more a `pre-commit` docs issue however.

- James Peach


On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> -----------------------------------------------------------
> 
> (Updated July 30, 2019, 9:01 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
>     https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -----
> 
>   .pre-commit-config.yaml PRE-CREATION 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/setup_dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup_dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/6/
> 
> 
> Testing
> -------
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>