[jira] [Commented] (FLINK-25246) Make benchmarks runnable on Java 11

["Anton Kalashnikov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480090#comment-17480090 ] 

Anton Kalashnikov commented on FLINK-25246:
-------------------------------------------

What I did already:
 * Installed JDK11 on jenkins agent
 * Added the new jdk tool to jenkins
 * Changed pom for flink-benchmarks with parameterizing of executable of exec plugin
 * Updated jenkins build 'flink-benchmark-request' with parameterizing of java version

After all these changes I am able to run at least `flink-benchmark-request` with Java11.

If we want always use java11 for all builds, most of my changes can be reverted and we need to do only the following things:
 * Set java11 as default on agent
 * Change JAVA_HOME on jenkins

[~chesnay] , [~pnowojski] , I still have some questions:
 * Do we want to have the ability to run all builds with both java versions?
 * Do we want to distinguish the results between java 8 and 11? If yes, perhaps we need to create a new environment in codespeed?
 * Do I understand correctly, that we want to use java 11 for both running and compilation (flink + benchmark)?

In my opinion, if we want to have the build which is able to manually run benchmarks on java 11 and we want to use this build for testing java11, then my current changes should be enough.

 

> Make benchmarks runnable on Java 11
> -----------------------------------
>
>                 Key: FLINK-25246
>                 URL: https://issues.apache.org/jira/browse/FLINK-25246
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Benchmarks
>            Reporter: Chesnay Schepler
>            Assignee: Anton Kalashnikov
>            Priority: Major
>              Labels: pull-request-available
>
> We should find a way to run our benchmarks on Java 11 to prepare for an eventual migration. Whether this means running Java 8/11 side-by-side, or only Java 11 is up for debate.
> To clarify, this ticket is only about setting up the infrastructure, not about resolving any performance issues.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)