[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6281: Fix grammatical errors on en.json

[GitBox <gi...@apache.org>]

JoaoJandre commented on code in PR #6281:
URL: https://github.com/apache/cloudstack/pull/6281#discussion_r856232534


##########
ui/public/locales/ar.json:
##########
@@ -93,7 +93,7 @@
 "label.action.delete.network": "Delete Network",
 "label.action.delete.network.processing": "Deleting Network....",
 "label.action.delete.nexusvswitch": "Delete Nexus 1000v",
-"label.action.delete.nic": "Remove NIC",
+"label.action.remove.nic": "Remove NIC",

Review Comment:
   Everywhere else I saw this term as remove and not delete, and even the label text says remove. Futhermore, I think in ACS its more sensible to say remove instead of delete NIC, because in ACS the NICs cannot exist apart from a VM, it's not a separate entity, it can be added or removed from a VM, it cannot be created/destroyed in a vacuum. In the end, it's not that big of a deal, but it keeps the code cohesive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org