[GitHub] [kafka] C0urante commented on a diff in pull request #13475: KAFKA-14652: Add the flow to the log context and the Connect-managed …

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on code in PR #13475:
URL: https://github.com/apache/kafka/pull/13475#discussion_r1200807046


##########
config/connect-mirror-maker.properties:
##########
@@ -57,3 +57,6 @@ config.storage.replication.factor=1
 # replication.policy.separator = _
 # sync.topic.acls.enabled = false
 # emit.heartbeats.interval.seconds = 5
+
+# enable flow in the logs for improved diagnostics
+add.flow.context = true

Review Comment:
   I left my thoughts on the discussion thread, but TL;DR: I think disabling by default both programmatically and in relevant config files is the safest (and follows precedent set by prior KIPs to added connector contexts to log files), and we can add a commented-out line to relevant config files that would enable the new log context behavior and add an explanation above it with our recommendations to users to un-comment it if they're starting new clusters or if their logging infrastructure is prepared to handle the changes it would cause.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org