[GitHub] [beam] alexeyinkin commented on a diff in pull request #26732: returned run shortcut, fixed pipeline options validation, added logs to ToB tests

["alexeyinkin (via GitHub)" <gi...@apache.org>]

alexeyinkin commented on code in PR #26732:
URL: https://github.com/apache/beam/pull/26732#discussion_r1196001070


##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -86,6 +88,7 @@ Future<void> _checkModule(ModuleModel module, WidgetTester wt) async {
 }
 
 Future<void> _checkNode(UnitModel node, WidgetTester wt) async {
+  print('Checking node: ${node.title}');

Review Comment:
   Move from the test to the code, add the failing example info to the exception.
   `ExampleLoadingDescriptor.token`



##########
playground/frontend/lib/modules/shortcuts/components/shortcuts_dialog.dart:
##########
@@ -44,6 +44,7 @@ class ShortcutsDialogContent extends StatelessWidget {
         children: [
           ...[
             ...playgroundController.shortcuts,
+            BeamMainRunShortcut(onInvoke: () {}),

Review Comment:
   Any more ideas?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org