You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "yesamer (via GitHub)" <gi...@apache.org> on 2024/05/07 13:00:51 UTC
[PR] kie-issues#1163: incubator-kie-tools missing header files [incubator-kie-tools]
yesamer opened a new pull request, #2298:
URL: https://github.com/apache/incubator-kie-tools/pull/2298
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1163: incubator-kie-tools missing header files [incubator-kie-tools]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli merged PR #2298:
URL: https://github.com/apache/incubator-kie-tools/pull/2298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1163: incubator-kie-tools missing header files [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2298:
URL: https://github.com/apache/incubator-kie-tools/pull/2298#issuecomment-2100949425
Thank you @Josephblt for checking!!
I intentionally ignored some java files because:
- In dashbuilder, a set of java files are used to test a code generation feature, and adding the headers leads to some tests failures
- Some java class file are a copy from other libraries. In such a case I don't know how to handle that
In any case, I'll double check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1163: incubator-kie-tools missing header files [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2298:
URL: https://github.com/apache/incubator-kie-tools/pull/2298#issuecomment-2100721823
@porcelli @LightGuard DISCLAIMER added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1163: incubator-kie-tools missing header files [incubator-kie-tools]
Posted by "Josephblt (via GitHub)" <gi...@apache.org>.
Josephblt commented on PR #2298:
URL: https://github.com/apache/incubator-kie-tools/pull/2298#issuecomment-2100921204
Hello @yesamer. I used a bash script (check_header.sh) to check the headers using the kie-tools-rad-report file.
[check_header.sh](https://gist.github.com/Josephblt/873fd9c9b904e4a3a2a6d37ffa1ad91a)
[kie-tools-rad-report.txt](https://gist.github.com/Josephblt/5fb6299509219fd2a01c97ac03372fc7)
To use the script:
Paste the file check_header.sh to kie-tools directory
Paste the file kie-tools-rad-report.txt to kie-tools directory
Run check_headers script ($./{kie-tools directory}/./check_header.sh.
Here is the list of files without headers I found:
[results.txt](https://gist.github.com/Josephblt/2980d4ddf084a1f10102452e9e3fcfdb)
Although it is possible that some of the files could be ignored, there are lots of .java files that are likely to be problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org