You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by st...@spamgourmet.com on 2011/07/11 21:44:39 UTC
Documentation styles missing some classes?
This could be intentional, but I believe the "space.css" style stylesheet lost the CSS class definition for ".tipMacro." This makes the docs look a little less nice in v2.2.3 than in v2.0.14.
Compare the green package heirarchy tip boxes between:
http://struts.apache.org/2.0.14/docs/localization.html
and
http://struts.apache.org/2.2.3/docs/localization.html
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Documentation styles missing some classes?
Posted by Łukasz Lenart <lu...@googlemail.com>.
Done, please try now.
2011/7/12 <st...@spamgourmet.com>:
> Much improved, thank you Łukasz!
>
> Other differences (arguably minor regressions):
>
> * There appears to be an unevaluated macro at the top of the page -- #editReport() in div#PageContent div.pagesubheading -- velocity vs. freemarker issue?
>
> * master.css line 12 sets the font-size to 10pt -- this overrides space.css's font-size: 11px. "9pt" would more closely approximate the previous size, but probably doesn't matter much. Or you could simply remove master.css's font-size definition to fall-back to the space.css definition.
>
> * table.tipMacro used to be center aligned via deprecated HTML attributes. To emulate with CSS, set "margin: 5px auto;" in space.css (and remove the now redundant margin-top and margin-bottom properties, since they've been folded into the shorthand definition)
>
> * table.tipMacro used to have a bit of padding via deprecated HTML attributes. Perhaps simply space.css line 1152 could add "padding: 5px;" to table.tipMacro
>
> Sincerely,
> rgm
>
>
> On Jul 12, 2011, at 4:24 AM, Łukasz Lenart - lukasz.lenart@googlemail.com wrote:
>
>> Could you check now ?
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>> Warszawa JUG conference - Confitura http://confitura.pl/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Documentation styles missing some classes?
Posted by Łukasz Lenart <lu...@googlemail.com>.
Could you check now ?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Documentation styles missing some classes?
Posted by Dave Newton <da...@gmail.com>.
I thought we just used the default Confluence styles, but perhaps I'm mistaken.
Dave
On Monday, July 11, 2011, Luiz Roberto Meier <lu...@gmail.com> wrote:
> I liked the stylesheet of v2.0.14 example. I hope that this change was just
> a mistake.
>
> On Mon, Jul 11, 2011 at 4:44 PM, <st...@spamgourmet.com> wrote:
>
>> This could be intentional, but I believe the "space.css" style stylesheet
>> lost the CSS class definition for ".tipMacro." This makes the docs look a
>> little less nice in v2.2.3 than in v2.0.14.
>> Compare the green package heirarchy tip boxes between:
>> http://struts.apache.org/2.0.14/docs/localization.html
>> and
>> http://struts.apache.org/2.2.3/docs/localization.html
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>>
>
>
> --
> Luiz Roberto Meier
> (51) 92.322.911
> luizrobertomeier@gmail.com
> meier@ufrgs.br
> http://br.linkedin.com/in/lrm2011
> --
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Documentation styles missing some classes?
Posted by Emi Lu <em...@encs.concordia.ca>.
I think the code-section display in the 2.0.14 is better:
http://struts.apache.org/2.0.14/docs/localization.html
Emi
>
> On Mon, Jul 11, 2011 at 4:44 PM,<st...@spamgourmet.com> wrote:
>
>> This could be intentional, but I believe the "space.css" style stylesheet
>> lost the CSS class definition for ".tipMacro." This makes the docs look a
>> little less nice in v2.2.3 than in v2.0.14.
>> Compare the green package heirarchy tip boxes between:
>> http://struts.apache.org/2.0.14/docs/localization.html
>> and
>> http://struts.apache.org/2.2.3/docs/localization.html
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>>
>
>
--
Emi Lu, ENCS, Concordia University, Montreal H3G 1M8
emilu@encs.concordia.ca +1 514 848-2424 x5884
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Documentation styles missing some classes?
Posted by Luiz Roberto Meier <lu...@gmail.com>.
I liked the stylesheet of v2.0.14 example. I hope that this change was just
a mistake.
On Mon, Jul 11, 2011 at 4:44 PM, <st...@spamgourmet.com> wrote:
> This could be intentional, but I believe the "space.css" style stylesheet
> lost the CSS class definition for ".tipMacro." This makes the docs look a
> little less nice in v2.2.3 than in v2.0.14.
> Compare the green package heirarchy tip boxes between:
> http://struts.apache.org/2.0.14/docs/localization.html
> and
> http://struts.apache.org/2.2.3/docs/localization.html
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>
--
Luiz Roberto Meier
(51) 92.322.911
luizrobertomeier@gmail.com
meier@ufrgs.br
http://br.linkedin.com/in/lrm2011
--