You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/08/01 16:52:32 UTC
Review Request 13192: create private network test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/
-----------------------------------------------------------
Review request for cloudstack, Koushik Das and Sheng Yang.
Bugs: CLOUDSTACK-1532
Repository: cloudstack-git
Description
-------
This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
Diffs
-----
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/13192/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request 13192: create private network test
Posted by Daan Hoogland <da...@gmail.com>.
someone broke the jenkins patch submission builds with a checkin. I
think no patch passes jenkins anymore because of the usage server not
building anymore. The patch build in my env in two different branches
(master and my work branch). The
Apache CloudStack Server4.6 sec << my changes
Apache CloudStack Test1.4 sec
Apache CloudStack Usage Server1.6 sec << broken!
Apache CloudStack Utils1 min 21 sec
this seems to be the case since
Commit 03046b4b50725f3d7299eaebfa6f7704b5168058 by wido
upgrade: Add SQL file for 4.2 -> 4.3 upgrade
setup/db/db/schema-420to430.sql
three commits where put on top of it :(
regards,
On Thu, Aug 1, 2013 at 5:18 PM, Jenkins Cloudstack.org <hu...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
>
> Review 13192 failed the build test : FAILURE
> The url of build cloudstack-master-with-patch #102 is :
> http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/102/
>
>
> - Jenkins Cloudstack.org
>
>
> On August 1st, 2013, 2:52 p.m. UTC, daan Hoogland wrote:
>
> Review request for cloudstack, Koushik Das and Sheng Yang.
> By daan Hoogland.
>
> Updated Aug. 1, 2013, 2:52 p.m.
>
> Bugs: CLOUDSTACK-1532
> Repository: cloudstack-git
>
> Description
>
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It
> occurred to me it can be submitted separately.
>
> Diffs
>
> server/test/com/cloud/network/CreatePrivateNetworkTest.java (PRE-CREATION)
>
> View Diff
Re: Review Request 13192: create private network test
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24443
-----------------------------------------------------------
Review 13192 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #102 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/102/
- Jenkins Cloudstack.org
On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 2:52 p.m.)
>
>
> Review request for cloudstack, Koushik Das and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-1532
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
>
>
> Diffs
> -----
>
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 13192: create private network test
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24571
-----------------------------------------------------------
Ship it!
Needs license headers. Fixed locally and committed. Please ensure forthcoming patches have license header.
Please close review
- Chiradeep Vittal
On Aug. 2, 2013, 8:24 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 8:24 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, Koushik Das, and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-1532
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
>
>
> Diffs
> -----
>
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 13192: create private network test
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 8:24 p.m.)
Review request for cloudstack, Chiradeep Vittal, Koushik Das, and Sheng Yang.
Bugs: CLOUDSTACK-1532
Repository: cloudstack-git
Description
-------
This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
Diffs
-----
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/13192/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request 13192: create private network test
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 8:23 p.m.)
Review request for cloudstack, Koushik Das and Sheng Yang.
Changes
-------
output to log
Bugs: CLOUDSTACK-1532
Repository: cloudstack-git
Description
-------
This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
Diffs (updated)
-----
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/13192/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request 13192: create private network test
Posted by daan Hoogland <da...@gmail.com>.
> On Aug. 2, 2013, 5:26 p.m., Chiradeep Vittal wrote:
> > server/test/com/cloud/network/CreatePrivateNetworkTest.java, line 163
> > <https://reviews.apache.org/r/13192/diff/1/?file=332329#file332329line163>
> >
> > Use logger.error instead of printStackTrace? This way the logfile will contain the error.
will do
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24547
-----------------------------------------------------------
On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 2:52 p.m.)
>
>
> Review request for cloudstack, Koushik Das and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-1532
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
>
>
> Diffs
> -----
>
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 13192: create private network test
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24547
-----------------------------------------------------------
server/test/com/cloud/network/CreatePrivateNetworkTest.java
<https://reviews.apache.org/r/13192/#comment48572>
Use logger.error instead of printStackTrace? This way the logfile will contain the error.
- Chiradeep Vittal
On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13192/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 2:52 p.m.)
>
>
> Review request for cloudstack, Koushik Das and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-1532
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately.
>
>
> Diffs
> -----
>
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>