[GitHub] [pulsar] codelipenghui commented on pull request #17618: [fix][broker][functions-worker] Ensure prometheus metrics are grouped by type (#8407, #13865)

[GitBox <gi...@apache.org>]

codelipenghui commented on PR #17618:
URL: https://github.com/apache/pulsar/pull/17618#issuecomment-1256848175

   @marksilcox Sorry, I have to revert this PR since it introduced a memory leak that was detected by a long-running continuous verification test. 
   
   The reproduction steps:
   
   1. Start a standalone
   2. Create a partitioned topic (100 partitions)
   3. Start producer `bin/pulsar-perf produce test -r 100 -bm 1 -mk random`
   4. Start consumer `bin/pulsar-perf consume -st Key_Shared -r 100 -n 50 test`
   5. Access the metrics endpoint
   
   ```shell
   for i in {1..1000}
   do
   curl -L localhost:8080/metrics/
   done
   ```
   
   <img width="748" alt="image" src="https://user-images.githubusercontent.com/12592133/192078282-bf3e1b50-9f54-485b-a2dc-283f9d6966ff.png">
   
   After reverting this PR, the memory leak issue has been fixed.
   
   <img width="822" alt="image" src="https://user-images.githubusercontent.com/12592133/192078735-9d023a85-b822-4a80-aa76-7f94360e926f.png">
   
   I'm not sure where is the root cause yet. Since many people are built based on the Pulsar release branches, so we'd better revert first and then fix the memory issue and create a new PR again. @marksilcox If you need help with the memory leak issue, I believe @tjiuming or @asafm can provide some insight here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org