You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by fred521 <gi...@git.apache.org> on 2018/12/10 22:51:06 UTC
[GitHub] zeppelin pull request #3259: Upgrade Jetty version to the latest version - 9...
GitHub user fred521 opened a pull request:
https://github.com/apache/zeppelin/pull/3259
Upgrade Jetty version to the latest version - 9.4.14.v20181114
### What is this PR for?
Our service frequently failed because of exception from the websocket.
Upgrade to the latest Jetty version to fix the hang issue if the websocket endpoint is invalid.
9.4.14.v20181114
https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.14.v20181114
9.4.13.v20181111
https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.13.v20181111
+ 2875 Fix WebSocketClient.connect() hang when attempting to connect at an
invalid websocket endpoint
### What type of PR is it?
Bug Fix & Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3902
Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-3902]
### How should this be tested?
Tested in the dev server and production
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fred521/zeppelin fdai/upgradeJettyVersion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3259
----
commit cbb340d423a2652e248105ce092c4657455d72fd
Author: fdai <fd...@...>
Date: 2018-12-06T21:29:17Z
upgrade jetty version
----
---
[GitHub] zeppelin issue #3259: Upgrade Jetty version to the latest version - 9.4.14.v...
Posted by fred521 <gi...@git.apache.org>.
Github user fred521 commented on the issue:
https://github.com/apache/zeppelin/pull/3259
Yes, It passes all the tests
On Tue, Dec 11, 2018 at 6:31 PM Jongyoul Lee <no...@github.com>
wrote:
> Could you please check your CI? I think this should pass all of our tests
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/3259#issuecomment-446439022>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AC9O8e34dbOrd6jwCOGJBLr0X759Acg1ks5u4GqfgaJpZM4ZMVYd>
> .
>
---
[GitHub] zeppelin issue #3259: Upgrade Jetty version to the latest version - 9.4.14.v...
Posted by fred521 <gi...@git.apache.org>.
Github user fred521 commented on the issue:
https://github.com/apache/zeppelin/pull/3259
here is the link
https://ci.appveyor.com/project/ApacheSoftwareFoundation/zeppelin/builds/20912238
On Tue, Dec 11, 2018 at 6:37 PM Fred <da...@gmail.com> wrote:
> Yes, It passes all the tests
>
> On Tue, Dec 11, 2018 at 6:31 PM Jongyoul Lee <no...@github.com>
> wrote:
>
>> Could you please check your CI? I think this should pass all of our tests
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/zeppelin/pull/3259#issuecomment-446439022>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AC9O8e34dbOrd6jwCOGJBLr0X759Acg1ks5u4GqfgaJpZM4ZMVYd>
>> .
>>
>
---
[GitHub] zeppelin issue #3259: Upgrade Jetty version to the latest version - 9.4.14.v...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3259
We had two different CI. one is for appveyor which actually doesn't test anything. another one is travis. Could you please check your travis? I don't think you set the CI correctly. Please see https://travis-ci.org/fred521/zeppelin/
---
[GitHub] zeppelin issue #3259: Upgrade Jetty version to the latest version - 9.4.14.v...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3259
Could you please check your CI? I think this should pass all of our tests
---
[GitHub] zeppelin pull request #3259: Upgrade Jetty version to the latest version - 9...
Posted by fred521 <gi...@git.apache.org>.
Github user fred521 closed the pull request at:
https://github.com/apache/zeppelin/pull/3259
---