You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/03/06 10:00:43 UTC
[GitHub] activemq-artemis pull request #1933: ARTEMIS-1731 Support offline validation
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1933
ARTEMIS-1731 Support offline validation
Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml works offline.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1933
----
commit 055c51d6b1eba2ecdc665138e6545f2c75c67349
Author: Michael André Pearce <mi...@...>
Date: 2018-03-06T09:58:12Z
ARTEMIS-1731 Support offline validation
Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml works offline.
----
---
[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1933
Please feel free to submit and alternative approach
---
[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1933
@michaelandrepearce I thought the right way to do this was through using the actual HTTP location. and have tools to cache it somehow.
In what scenario this is failing? on deploy on master, when running behing a firewal? or when using an external tool for this?
---
[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1933
From the [JIRA](https://issues.apache.org/jira/browse/ARTEMIS-1731), "...starting Artemis fails when the server running broker has no Internet access."
---
[GitHub] activemq-artemis pull request #1933: ARTEMIS-1731 Support offline validation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1933
---
[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation
Posted by obfischer <gi...@git.apache.org>.
Github user obfischer commented on the issue:
https://github.com/apache/activemq-artemis/pull/1933
I wouldn't change the `schemaLocation` directly as it is actual a bad practice. Dependending on the XML processor catalog files should be used. In most cases the API of the XML processor allows you to handle such things in a cleaner way.
---
[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1933
@jbertram I see.. nice it was caught before the release...
I'm merging it...
@obfischer if you have a better way and still solve this issue.. I'm open for it.
---