You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Patrick Angeles <pa...@inertiabev.com> on 2008/08/19 00:21:12 UTC

FeedbackPanel default outputMarkupId = true

Does it make sense to have outputMarkupId default to true for FeedbackPanel?

Use case:

somePanel.add (new OnChangeAjaxBehavior() {
  protected void onUpdate (AjaxRequestTarget target) {
    // do stuff, 
    Session.get().info ("did stuff");
    target.addChildren (getPage(), FeedbackPanel.class) ;
  }
});

This code will work from anywhere in the component hierarchy, regardless of
which component added the  feedbackpanel, without the owning component
having to call feedback.setOutputMarkupId(true)...

I could just as well subclass FeedbackPanel but this seems like a common
enough case that it makes sense to build it into the core...


-- 
View this message in context: http://www.nabble.com/FeedbackPanel-default-outputMarkupId-%3D-true-tp19041186p19041186.html
Sent from the Wicket - User mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: FeedbackPanel default outputMarkupId = true

Posted by Nino Saturnino Martinez Vazquez Wael <ni...@jayway.dk>.
Hehe no completely true.. But it does generate more output.. However 
dosent matter much for me what the default are.. as long as I can set a 
property to control it:)

Matej Knopp wrote:
> Just making feedback panel write markup id doesn't mean your
> application has to be all ajaxy...
>
> -Matej
>
> On Tue, Aug 19, 2008 at 8:25 AM, Nino Saturnino Martinez Vazquez Wael
> <ni...@jayway.dk> wrote:
>   
>> I still for one try to get ajax away for public(unauthorized) parts,  for
>> seo and caching purposes but it depends on the situation..
>>
>> Timo Rantalaiho wrote:
>>     
>>> On Mon, 18 Aug 2008, Patrick Angeles wrote:
>>>
>>>       
>>>> Does it make sense to have outputMarkupId default to true for
>>>> FeedbackPanel?
>>>>
>>>> Use case:
>>>>
>>>> somePanel.add (new OnChangeAjaxBehavior() {
>>>>  protected void onUpdate (AjaxRequestTarget target) {
>>>>    // do stuff,    Session.get().info ("did stuff");
>>>>    target.addChildren (getPage(), FeedbackPanel.class) ;
>>>>  }
>>>> });
>>>>
>>>> This code will work from anywhere in the component hierarchy, regardless
>>>> of
>>>> which component added the  feedbackpanel, without the owning component
>>>> having to call feedback.setOutputMarkupId(true)...
>>>>
>>>> I could just as well subclass FeedbackPanel but this seems like a common
>>>> enough case that it makes sense to build it into the core...
>>>>
>>>>         
>>> With a suitable IComponentInstantiationListener you can
>>> probably achieve the wanted behavior in your own
>>> application.
>>>
>>>
>>> All my Wicket applications are very ajaxy, but maybe there
>>> is someone out there that is still doing the traditional
>>> whole- page-request stuff :) And a lot of defaults on Wicket
>>> are still based on that.
>>> It's kind of an established standard that by default,
>>> outputMarkupId is false, so in 1.3 or 1.4 I don't see it
>>> could be changed. Later on, if the change is made, maybe it
>>> would be better to change the default for all Components and
>>> not just FeedbackPanel.
>>>
>>> What do others think?
>>>
>>> Best wishes,
>>> Timo
>>>
>>>
>>>       
>> --
>> -Wicket for love
>>
>> Nino Martinez Wael
>> Java Specialist @ Jayway DK
>> http://www.jayway.dk
>> +45 2936 7684
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>>     
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>   

-- 
-Wicket for love

Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: FeedbackPanel default outputMarkupId = true

Posted by Matej Knopp <ma...@gmail.com>.
Just making feedback panel write markup id doesn't mean your
application has to be all ajaxy...

-Matej

On Tue, Aug 19, 2008 at 8:25 AM, Nino Saturnino Martinez Vazquez Wael
<ni...@jayway.dk> wrote:
> I still for one try to get ajax away for public(unauthorized) parts,  for
> seo and caching purposes but it depends on the situation..
>
> Timo Rantalaiho wrote:
>>
>> On Mon, 18 Aug 2008, Patrick Angeles wrote:
>>
>>>
>>> Does it make sense to have outputMarkupId default to true for
>>> FeedbackPanel?
>>>
>>> Use case:
>>>
>>> somePanel.add (new OnChangeAjaxBehavior() {
>>>  protected void onUpdate (AjaxRequestTarget target) {
>>>    // do stuff,    Session.get().info ("did stuff");
>>>    target.addChildren (getPage(), FeedbackPanel.class) ;
>>>  }
>>> });
>>>
>>> This code will work from anywhere in the component hierarchy, regardless
>>> of
>>> which component added the  feedbackpanel, without the owning component
>>> having to call feedback.setOutputMarkupId(true)...
>>>
>>> I could just as well subclass FeedbackPanel but this seems like a common
>>> enough case that it makes sense to build it into the core...
>>>
>>
>> With a suitable IComponentInstantiationListener you can
>> probably achieve the wanted behavior in your own
>> application.
>>
>>
>> All my Wicket applications are very ajaxy, but maybe there
>> is someone out there that is still doing the traditional
>> whole- page-request stuff :) And a lot of defaults on Wicket
>> are still based on that.
>> It's kind of an established standard that by default,
>> outputMarkupId is false, so in 1.3 or 1.4 I don't see it
>> could be changed. Later on, if the change is made, maybe it
>> would be better to change the default for all Components and
>> not just FeedbackPanel.
>>
>> What do others think?
>>
>> Best wishes,
>> Timo
>>
>>
>
> --
> -Wicket for love
>
> Nino Martinez Wael
> Java Specialist @ Jayway DK
> http://www.jayway.dk
> +45 2936 7684
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: FeedbackPanel default outputMarkupId = true

Posted by Nino Saturnino Martinez Vazquez Wael <ni...@jayway.dk>.
I still for one try to get ajax away for public(unauthorized) parts,  
for seo and caching purposes but it depends on the situation..

Timo Rantalaiho wrote:
> On Mon, 18 Aug 2008, Patrick Angeles wrote:
>   
>> Does it make sense to have outputMarkupId default to true for FeedbackPanel?
>>
>> Use case:
>>
>> somePanel.add (new OnChangeAjaxBehavior() {
>>   protected void onUpdate (AjaxRequestTarget target) {
>>     // do stuff, 
>>     Session.get().info ("did stuff");
>>     target.addChildren (getPage(), FeedbackPanel.class) ;
>>   }
>> });
>>
>> This code will work from anywhere in the component hierarchy, regardless of
>> which component added the  feedbackpanel, without the owning component
>> having to call feedback.setOutputMarkupId(true)...
>>
>> I could just as well subclass FeedbackPanel but this seems like a common
>> enough case that it makes sense to build it into the core...
>>     
>
> With a suitable IComponentInstantiationListener you can
> probably achieve the wanted behavior in your own
> application.
>
>
> All my Wicket applications are very ajaxy, but maybe there
> is someone out there that is still doing the traditional
> whole- page-request stuff :) And a lot of defaults on Wicket
> are still based on that. 
>
> It's kind of an established standard that by default,
> outputMarkupId is false, so in 1.3 or 1.4 I don't see it
> could be changed. Later on, if the change is made, maybe it
> would be better to change the default for all Components and
> not just FeedbackPanel.
>
> What do others think?
>
> Best wishes,
> Timo
>
>   

-- 
-Wicket for love

Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: FeedbackPanel default outputMarkupId = true

Posted by Ryan Sonnek <ry...@gmail.com>.
>
> It's kind of an established standard that by default,
> outputMarkupId is false, so in 1.3 or 1.4 I don't see it
> could be changed. Later on, if the change is made, maybe it
> would be better to change the default for all Components and
> not just FeedbackPanel.
>

+1 from me.  I don't see any reason to *not* output the markup id by
default.  It would make the transition to ajax-ifying your application just
a little easier.  The only thing you need to worry about is if someone tries
to use that markup id for css styling since those markup ids are subject to
change.

Re: FeedbackPanel default outputMarkupId = true

Posted by Timo Rantalaiho <Ti...@ri.fi>.
On Mon, 18 Aug 2008, Patrick Angeles wrote:
> Does it make sense to have outputMarkupId default to true for FeedbackPanel?
> 
> Use case:
> 
> somePanel.add (new OnChangeAjaxBehavior() {
>   protected void onUpdate (AjaxRequestTarget target) {
>     // do stuff, 
>     Session.get().info ("did stuff");
>     target.addChildren (getPage(), FeedbackPanel.class) ;
>   }
> });
> 
> This code will work from anywhere in the component hierarchy, regardless of
> which component added the  feedbackpanel, without the owning component
> having to call feedback.setOutputMarkupId(true)...
> 
> I could just as well subclass FeedbackPanel but this seems like a common
> enough case that it makes sense to build it into the core...

With a suitable IComponentInstantiationListener you can
probably achieve the wanted behavior in your own
application.


All my Wicket applications are very ajaxy, but maybe there
is someone out there that is still doing the traditional
whole- page-request stuff :) And a lot of defaults on Wicket
are still based on that. 

It's kind of an established standard that by default,
outputMarkupId is false, so in 1.3 or 1.4 I don't see it
could be changed. Later on, if the change is made, maybe it
would be better to change the default for all Components and
not just FeedbackPanel.

What do others think?

Best wishes,
Timo

-- 
Timo Rantalaiho           
Reaktor Innovations Oy    <URL: http://www.ri.fi/ >

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org